Use stricter type checking in UMA_HISTOGRAM_ENUMERATION

components/password_manager/core/browser/password_syncable_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/password_syncable_service.h"
 
 #include <algorithm>
 #include <iterator>
 #include <utility>
 
@@ skipping 283 matching lines @@
 bool PasswordSyncableService::ReadFromPasswordStore(
     std::vector<std::unique_ptr<autofill::PasswordForm>>* password_entries,
     PasswordEntryMap* passwords_entry_map) const {
   DCHECK(password_entries);
   std::vector<std::unique_ptr<autofill::PasswordForm>> autofillable_entries;
   std::vector<std::unique_ptr<autofill::PasswordForm>> blacklist_entries;
   if (!password_store_->FillAutofillableLogins(&autofillable_entries) ||
       !password_store_->FillBlacklistLogins(&blacklist_entries)) {
     // Password store often fails to load passwords. Track failures with UMA.
     // (http://crbug.com/249000)
+    // TODO(wychen): enum uma should be strongly typed. crbug.com/661401
     UMA_HISTOGRAM_ENUMERATION("Sync.LocalDataFailedToLoad",
                               ModelTypeToHistogramInt(syncer::PASSWORDS),
-                              syncer::MODEL_TYPE_COUNT);
+                              static_cast<int>(syncer::MODEL_TYPE_COUNT));
     return false;
   }
   password_entries->resize(autofillable_entries.size() +
                            blacklist_entries.size());
   std::move(autofillable_entries.begin(), autofillable_entries.end(),
             password_entries->begin());
   std::move(blacklist_entries.begin(), blacklist_entries.end(),
             password_entries->begin() + autofillable_entries.size());
 
   if (!passwords_entry_map)
@@ skipping 148 matching lines @@
 
 std::string MakePasswordSyncTag(const autofill::PasswordForm& password) {
   return (net::EscapePath(password.origin.spec()) + "|" +
           net::EscapePath(base::UTF16ToUTF8(password.username_element)) + "|" +
           net::EscapePath(base::UTF16ToUTF8(password.username_value)) + "|" +
           net::EscapePath(base::UTF16ToUTF8(password.password_element)) + "|" +
           net::EscapePath(password.signon_realm));
 }
 
 }  // namespace password_manager