|
|
DescriptionRemove usage of SequencedWorkerPool::GetNamedSequenceToken from DOMStorageContextWrapper.
SequencedWorkerPool is being deprecated in favor of TaskScheduler.
BUG=667892
Review-Url: https://codereview.chromium.org/2883393002
Cr-Commit-Position: refs/heads/master@{#473324}
Committed: https://chromium.googlesource.com/chromium/src/+/0d20e12ffabd4d74470e18c1cde77b8b7caed346
Patch Set 1 #Patch Set 2 : self-review #
Total comments: 6
Patch Set 3 : CR-michaeln-11 #Messages
Total messages: 21 (15 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
fdoray@chromium.org changed reviewers: + michaeln@chromium.org
Please take a look. https://codereview.chromium.org/2883393002/diff/20001/content/browser/dom_sto... File content/browser/dom_storage/dom_storage_context_wrapper.cc (left): https://codereview.chromium.org/2883393002/diff/20001/content/browser/dom_sto... content/browser/dom_storage/dom_storage_context_wrapper.cc:93: if (GetContentClient()->browser()->ShouldRedirectDOMStorageTaskRunner()) { ShouldRedirectDOMStorageTaskRunner() will be removed in a separate file. https://codereview.chromium.org/2883393002/diff/20001/content/browser/dom_sto... File content/browser/dom_storage/dom_storage_context_wrapper.cc (right): https://codereview.chromium.org/2883393002/diff/20001/content/browser/dom_sto... content/browser/dom_storage/dom_storage_context_wrapper.cc:91: base::TaskShutdownBehavior::BLOCK_SHUTDOWN}; Please confirm that this traits are correct.
https://codereview.chromium.org/2883393002/diff/20001/content/browser/dom_sto... File content/browser/dom_storage/dom_storage_context_wrapper.cc (right): https://codereview.chromium.org/2883393002/diff/20001/content/browser/dom_sto... content/browser/dom_storage/dom_storage_context_wrapper.cc:91: base::TaskShutdownBehavior::BLOCK_SHUTDOWN}; On 2017/05/17 17:14:22, fdoray wrote: > Please confirm that this traits are correct. The PRIMARY sequence is USER_BLOCKING The COMMIT sequence is BACKGROUND var x = window.localStorage['foo'] blocks on primary sequence tasks https://codereview.chromium.org/2883393002/diff/20001/content/browser/dom_sto... content/browser/dom_storage/dom_storage_context_wrapper.cc:92: auto primary_sequence = nit: since we're line wrapped anyway, maybe don't use auto for the local
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAnL https://codereview.chromium.org/2883393002/diff/20001/content/browser/dom_sto... File content/browser/dom_storage/dom_storage_context_wrapper.cc (right): https://codereview.chromium.org/2883393002/diff/20001/content/browser/dom_sto... content/browser/dom_storage/dom_storage_context_wrapper.cc:91: base::TaskShutdownBehavior::BLOCK_SHUTDOWN}; On 2017/05/19 00:14:04, michaeln wrote: > On 2017/05/17 17:14:22, fdoray wrote: > > Please confirm that this traits are correct. > > The PRIMARY sequence is USER_BLOCKING > The COMMIT sequence is BACKGROUND > > var x = window.localStorage['foo'] blocks on primary sequence tasks Done. https://codereview.chromium.org/2883393002/diff/20001/content/browser/dom_sto... content/browser/dom_storage/dom_storage_context_wrapper.cc:92: auto primary_sequence = On 2017/05/19 00:14:04, michaeln wrote: > nit: since we're line wrapped anyway, maybe don't use auto for the local Done.
LGTM
The CQ bit was unchecked by fdoray@chromium.org
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495221808626460, "parent_rev": "69008afaa78dd9d2fc012b3fcb8f2e0a56fc0a1d", "commit_rev": "0d20e12ffabd4d74470e18c1cde77b8b7caed346"}
Message was sent while issue was closed.
Description was changed from ========== Remove usage of SequencedWorkerPool::GetNamedSequenceToken from DOMStorageContextWrapper. SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 ========== to ========== Remove usage of SequencedWorkerPool::GetNamedSequenceToken from DOMStorageContextWrapper. SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 Review-Url: https://codereview.chromium.org/2883393002 Cr-Commit-Position: refs/heads/master@{#473324} Committed: https://chromium.googlesource.com/chromium/src/+/0d20e12ffabd4d74470e18c1cde7... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/0d20e12ffabd4d74470e18c1cde7... |