[SmartText selection] Implement TextClassifier getter and setter

[SmartText selection] Implement TextClassifier getter and setter

Pass the text classifier object by the chain
  AwContents -> ContentViewCore -> SelectionPopupController ->
  SmartSelectionClient -> SmartSelectionProvider.

The classifier is supposed to be owned by the implementation of
SmartSelectionProvider.

Move the classifier object to the new popup contents in case of
popup creation.

BUG=710503
Review-Url: https://codereview.chromium.org/2882583004
Cr-Commit-Position: refs/heads/master@{#472643}
Committed: https://chromium.googlesource.com/chromium/src/+/0d7d2b26b79f0d75280911e80ccc22c77fe80cb5

[Tima Vaisburd, 2017-05-13 02:40:23]

The CQ bit was checked by timav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-13 02:40:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tima Vaisburd, 2017-05-13 02:45:04]

This CL replaces https://codereview.chromium.org/2835323003

[Tima Vaisburd, 2017-05-13 03:05:14]

timav@chromium.org changed reviewers:
+ boliu@chromium.org

[Tima Vaisburd, 2017-05-13 03:05:15]

Reimplemented and hopefully simplified. PTAL.

[commit-bot: I haz the power, 2017-05-13 04:08:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 04:08:27]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[boliu, 2017-05-15 16:50:21]

https://codereview.chromium.org/2882583004/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
(right):

https://codereview.chromium.org/2882583004/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java:1110:
mSelectionClient.setTextClassifier(textClassifier);
null checks, as found out by tests:

05-13 04:05:27.239 29770 29770 E AndroidRuntime: java.lang.NullPointerException
05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
org.chromium.content.browser.SelectionPopupController.getCustomTextClassifier(SelectionPopupController.java:1129)
05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
org.chromium.content.browser.ContentViewCore.getCustomTextClassifier(ContentViewCore.java:2369)
05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
org.chromium.android_webview.AwContents.setNewAwContents(AwContents.java:1044)
05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
org.chromium.android_webview.AwContents.receivePopupContents(AwContents.java:1146)
05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
org.chromium.android_webview.AwContents.supplyContentsForPopup(AwContents.java:1115)
05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
org.chromium.android_webview.test.AwTestBase$27.run(AwTestBase.java:741)
05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
android.app.Instrumentation$SyncRunnable.run(Instrumentation.java:1719)
05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
android.os.Handler.handleCallback(Handler.java:733)
05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
android.os.Handler.dispatchMessage(Handler.java:95)
05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
android.os.Looper.loop(Looper.java:136)
05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
android.app.ActivityThread.main(ActivityThread.java:5001)
05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
java.lang.reflect.Method.invokeNative(Native Method)
05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
java.lang.reflect.Method.invoke(Method.java:515)
05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
dalvik.system.NativeStart.main(Native Method)

[Tima Vaisburd, 2017-05-15 23:17:04]

The CQ bit was checked by timav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 23:17:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 01:46:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 01:46:04]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Tima Vaisburd, 2017-05-16 07:29:03]

The CQ bit was checked by timav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 07:29:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 08:13:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 08:13:56]

Dry run: This issue passed the CQ dry run.

[Tima Vaisburd, 2017-05-16 08:42:00]

https://codereview.chromium.org/2882583004/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
(right):

https://codereview.chromium.org/2882583004/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java:1110:
mSelectionClient.setTextClassifier(textClassifier);
On 2017/05/15 16:50:21, boliu wrote:
> null checks, as found out by tests:
> 
> 05-13 04:05:27.239 29770 29770 E AndroidRuntime:
java.lang.NullPointerException
> 05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
>
org.chromium.content.browser.SelectionPopupController.getCustomTextClassifier(SelectionPopupController.java:1129)
> 05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
>
org.chromium.content.browser.ContentViewCore.getCustomTextClassifier(ContentViewCore.java:2369)
> 05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
> org.chromium.android_webview.AwContents.setNewAwContents(AwContents.java:1044)
> 05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
>
org.chromium.android_webview.AwContents.receivePopupContents(AwContents.java:1146)
> 05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
>
org.chromium.android_webview.AwContents.supplyContentsForPopup(AwContents.java:1115)
> 05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
> org.chromium.android_webview.test.AwTestBase$27.run(AwTestBase.java:741)
> 05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
> android.app.Instrumentation$SyncRunnable.run(Instrumentation.java:1719)
> 05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
> android.os.Handler.handleCallback(Handler.java:733)
> 05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
> android.os.Handler.dispatchMessage(Handler.java:95)
> 05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
> android.os.Looper.loop(Looper.java:136)
> 05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
> android.app.ActivityThread.main(ActivityThread.java:5001)
> 05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
> java.lang.reflect.Method.invokeNative(Native Method)
> 05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
> java.lang.reflect.Method.invoke(Method.java:515)
> 05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
>
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
> 05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
> com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
> 05-13 04:05:27.239 29770 29770 E AndroidRuntime: 	at
> dalvik.system.NativeStart.main(Native Method)

The try bots are green at last.

[boliu, 2017-05-16 14:17:22]

lgtm

[Tima Vaisburd, 2017-05-17 19:18:36]

The CQ bit was checked by timav@chromium.org

[Tima Vaisburd, 2017-05-17 19:18:36]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2882583004/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2017-05-17 19:20:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 19:53:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 19:53:21]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Tima Vaisburd, 2017-05-17 19:58:17]

timav@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Tima Vaisburd, 2017-05-17 19:58:18]

Ted, may I ask for the owner review, please?

[Ted C, 2017-05-18 00:11:08]

lgtm

[Tima Vaisburd, 2017-05-18 00:14:51]

The CQ bit was checked by timav@chromium.org

[commit-bot: I haz the power, 2017-05-18 00:17:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 00:28:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 00:28:48]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Tima Vaisburd, 2017-05-18 01:48:37]

The CQ bit was checked by timav@chromium.org

[Tima Vaisburd, 2017-05-18 01:48:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2882583004/#ps60001
(title: "Rebased again")

[commit-bot: I haz the power, 2017-05-18 01:50:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 03:42:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495072117465160,
"parent_rev": "f864061004f469cb239890d16ea306ada8e9fda0", "commit_rev":
"0d7d2b26b79f0d75280911e80ccc22c77fe80cb5"}

[commit-bot: I haz the power, 2017-05-18 03:42:37]

Description was changed from

==========
[SmartText selection] Implement TextClassifier getter and setter

Pass the text classifier object by the chain
  AwContents -> ContentViewCore -> SelectionPopupController ->
  SmartSelectionClient -> SmartSelectionProvider.

The classifier is supposed to be owned by the implementation of
SmartSelectionProvider.

Move the classifier object to the new popup contents in case of
popup creation.

BUG=710503
==========

to

==========
[SmartText selection] Implement TextClassifier getter and setter

Pass the text classifier object by the chain
  AwContents -> ContentViewCore -> SelectionPopupController ->
  SmartSelectionClient -> SmartSelectionProvider.

The classifier is supposed to be owned by the implementation of
SmartSelectionProvider.

Move the classifier object to the new popup contents in case of
popup creation.

BUG=710503

Review-Url: https://codereview.chromium.org/2882583004
Cr-Commit-Position: refs/heads/master@{#472643}
Committed:
https://chromium.googlesource.com/chromium/src/+/0d7d2b26b79f0d75280911e80ccc...
==========

[commit-bot: I haz the power, 2017-05-18 03:42:38]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0d7d2b26b79f0d75280911e80ccc...