Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1470)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/SmartSelectionClient.java

Issue 2882583004: [SmartText selection] Implement TextClassifier getter and setter (Closed)
Patch Set: Rebased again Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/SmartSelectionClient.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/SmartSelectionClient.java b/content/public/android/java/src/org/chromium/content/browser/SmartSelectionClient.java
index 95b2803ae2629547cb049b40b14fdb2386852bb8..ac1a2af87e5f6f958bebcb638434204e866a33b7 100644
--- a/content/public/android/java/src/org/chromium/content/browser/SmartSelectionClient.java
+++ b/content/public/android/java/src/org/chromium/content/browser/SmartSelectionClient.java
@@ -83,6 +83,9 @@ public class SmartSelectionClient implements SelectionClient {
public void showUnhandledTapUIIfNeeded(int x, int y) {}
@Override
+ public void selectWordAroundCaretAck(boolean didSelect, int startAdjust, int endAdjust) {}
+
+ @Override
public boolean requestSelectionPopupUpdates(boolean shouldSuggest) {
requestSurroundingText(shouldSuggest ? SUGGEST_AND_CLASSIFY : CLASSIFY);
return true;
@@ -97,8 +100,23 @@ public class SmartSelectionClient implements SelectionClient {
mProvider.cancelAllRequests();
}
+ // TODO(timav): Use |TextClassifier| instead of |Object| after we switch to Android SDK 26.
@Override
- public void selectWordAroundCaretAck(boolean didSelect, int startAdjust, int endAdjust) {}
+ public void setTextClassifier(Object textClassifier) {
+ mProvider.setTextClassifier(textClassifier);
+ }
+
+ // TODO(timav): Use |TextClassifier| instead of |Object| after we switch to Android SDK 26.
+ @Override
+ public Object getTextClassifier() {
+ return mProvider.getTextClassifier();
+ }
+
+ // TODO(timav): Use |TextClassifier| instead of |Object| after we switch to Android SDK 26.
+ @Override
+ public Object getCustomTextClassifier() {
+ return mProvider.getCustomTextClassifier();
+ }
private void requestSurroundingText(@RequestType int callbackData) {
if (mNativeSmartSelectionClient == 0) {

Powered by Google App Engine
This is Rietveld 408576698