Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2882583003:
Re-land: base: Avoid unnecessary allocations in base::FindThreadID. (Closed)
DescriptionRe-land: base: Avoid unnecessary allocations in base::FindThreadID.
Improve parsing by using StringTokenizer.
BUG=708765
Review-Url: https://chromiumcodereview.appspot.com/2882583003
Cr-Commit-Position: refs/heads/master@{#499448}
Committed: https://chromium.googlesource.com/chromium/src/+/e5aece57cbbf13af34d28a5e352e904f23a9146e
Patch Set 1 #Patch Set 2 : early out after finding NSpid #Patch Set 3 : fix DCHECK #Messages
Total messages: 21 (12 generated)
reveman@chromium.org changed reviewers: + brettw@chromium.org
Some simple initial optimizations.
LGTM, sorry I lost this.
The CQ bit was checked by reveman@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495570335353450,
"parent_rev": "b3971784fb6bcad679e433a9a6723fc66a51389e", "commit_rev":
"293c72b48fb321d33d6b06147807de9e4000924e"}
Message was sent while issue was closed.
Description was changed from ========== base: Avoid unnecessary allocations in base::FindThreadID. Improve parsing by using StringTokenizer. BUG=708765 ========== to ========== base: Avoid unnecessary allocations in base::FindThreadID. Improve parsing by using StringTokenizer. BUG=708765 Review-Url: https://codereview.chromium.org/2882583003 Cr-Commit-Position: refs/heads/master@{#474077} Committed: https://chromium.googlesource.com/chromium/src/+/293c72b48fb321d33d6b06147807... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/293c72b48fb321d33d6b06147807...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2900323002/ by reveman@chromium.org. The reason for reverting is: Causing crash: [FATAL:linux_util.cc(212)] Check failed: split_value_str.size() >= 3u (2 vs. 3).
Description was changed from ========== base: Avoid unnecessary allocations in base::FindThreadID. Improve parsing by using StringTokenizer. BUG=708765 Review-Url: https://codereview.chromium.org/2882583003 Cr-Commit-Position: refs/heads/master@{#474077} Committed: https://chromium.googlesource.com/chromium/src/+/293c72b48fb321d33d6b06147807... ========== to ========== Re-land: base: Avoid unnecessary allocations in base::FindThreadID. Improve parsing by using StringTokenizer. BUG=708765 Review-Url: https://codereview.chromium.org/2882583003 Cr-Commit-Position: refs/heads/master@{#474077} Committed: https://chromium.googlesource.com/chromium/src/+/293c72b48fb321d33d6b06147807... ==========
Description was changed from ========== Re-land: base: Avoid unnecessary allocations in base::FindThreadID. Improve parsing by using StringTokenizer. BUG=708765 Review-Url: https://codereview.chromium.org/2882583003 Cr-Commit-Position: refs/heads/master@{#474077} Committed: https://chromium.googlesource.com/chromium/src/+/293c72b48fb321d33d6b06147807... ========== to ========== Re-land: base: Avoid unnecessary allocations in base::FindThreadID. Improve parsing by using StringTokenizer. BUG=708765 ==========
The CQ bit was checked by reveman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org Link to the patchset: https://codereview.chromium.org/2882583003/#ps40001 (title: "fix DCHECK")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by reveman@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1504505665238730,
"parent_rev": "421ee4d888a432c47cde61140fec77d4c6ea7270", "commit_rev":
"e5aece57cbbf13af34d28a5e352e904f23a9146e"}
Message was sent while issue was closed.
Description was changed from ========== Re-land: base: Avoid unnecessary allocations in base::FindThreadID. Improve parsing by using StringTokenizer. BUG=708765 ========== to ========== Re-land: base: Avoid unnecessary allocations in base::FindThreadID. Improve parsing by using StringTokenizer. BUG=708765 Review-Url: https://chromiumcodereview.appspot.com/2882583003 Cr-Commit-Position: refs/heads/master@{#499448} Committed: https://chromium.googlesource.com/chromium/src/+/e5aece57cbbf13af34d28a5e352e... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/e5aece57cbbf13af34d28a5e352e... |
