Issue 2880323002: Move ownership of RtpTransportControllerSendInterface from Call to PeerConnection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2880323002: Move ownership of RtpTransportControllerSendInterface from Call to PeerConnection.

Created:
3 years, 7 months ago by nisse-webrtc

Modified:
3 years, 6 months ago

Reviewers:

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman

Target Ref:
refs/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Move ownership of RtpTransportControllerSendInterface from Call to PeerConnection. BUG=webrtc:7135

Patch Set 1 #

Patch Set 2 : Update rtc_media_unittests. #

Patch Set 3 : Add gn dependency for rtc_media_unittests. #

Patch Set 4 : Rebased. #

Patch Set 5 : Let CallTest inject rtp_transport_controller_send. #

Patch Set 6 : Update ortc code. Comment and constness tweaks. #

Patch Set 7 : Add call dependency to ortc. #

Patch Set 8 : More CallTest updates. #

Patch Set 9 : Delete shadowing member variables in BitrateEstimatorTest. #

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+190 lines, -80 lines)			Patch
M	webrtc/call/bitrate_estimator_tests.cc	View	1 2 3 4 5 6 7 8	2 chunks	+2 lines, -4 lines	0 comments	Download
M	webrtc/call/call.h	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	webrtc/call/call.cc	View	1 2 3	16 chunks	+37 lines, -42 lines	0 comments	Download
M	webrtc/call/call_unittest.cc	View	1 2 3 4 5 6 7	6 chunks	+23 lines, -8 lines	0 comments	Download
M	webrtc/call/fake_rtp_transport_controller_send.h	View	1 2 3 4 5 6 7	1 chunk	+5 lines, -0 lines	0 comments	Download
M	webrtc/call/rtp_transport_controller_send.h	View	1 2 3 4 5	1 chunk	+4 lines, -0 lines	0 comments	Download
M	webrtc/media/BUILD.gn	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	webrtc/media/base/videoengine_unittest.h	View	1	2 chunks	+12 lines, -2 lines	0 comments	Download
M	webrtc/media/engine/webrtcvideoengine2_unittest.cc	View	1 2 3 4 5	3 chunks	+13 lines, -1 line	0 comments	Download
M	webrtc/media/engine/webrtcvoiceengine_unittest.cc	View	1 2 3 4 5	6 chunks	+34 lines, -16 lines	0 comments	Download
M	webrtc/ortc/BUILD.gn	View	1 2 3 4 5 6	1 chunk	+1 line, -0 lines	0 comments	Download
M	webrtc/ortc/rtptransportcontrolleradapter.h	View	1 2 3 4 5	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webrtc/ortc/rtptransportcontrolleradapter.cc	View	1 2 3 4 5	2 chunks	+8 lines, -2 lines	0 comments	Download
M	webrtc/pc/peerconnection.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	webrtc/pc/peerconnection.cc	View		3 chunks	+10 lines, -1 line	0 comments	Download
M	webrtc/test/call_test.h	View	1 2 3 4	4 chunks	+6 lines, -2 lines	0 comments	Download
M	webrtc/test/call_test.cc	View	1 2 3 4	2 chunks	+17 lines, -2 lines	0 comments	Download