|
|
Created:
3 years, 7 months ago by fdoray Modified:
3 years, 7 months ago CC:
chromium-reviews, cbentzel+watch_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), net-reviews_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse TaskScheduler instead of SequencedWorkerPool in cookie_util.mm.
SequencedWorkerPool is being deprecated in favor of TaskScheduler.
BUG=667892
R=droger@chromium.org
Review-Url: https://codereview.chromium.org/2878943002
Cr-Commit-Position: refs/heads/master@{#473694}
Committed: https://chromium.googlesource.com/chromium/src/+/b4ee2b4a14244ae634817e234a3c911c0cf5a099
Patch Set 1 #
Messages
Total messages: 15 (9 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Please take a look. This CL was generated automatically. The base::MayBlock() trait was specified for all call sites and the base::TaskPriority::BACKGROUND trait was specified for all non-test call sites. That may not be appropriate for your use case. Please verify that appropriate traits were used https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h If everything looks good, lgtm and CQ this CL. Otherwise, tell us what's wrong. Thanks. - FAQ - What if bots are red? Ignore this CL. A human will look at errors shortly. What if the shutdown behavior is not set explicitly (no base::TaskShutdownBehavior)? If shutdown behavior is important for a task, it should be set explicitly. It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or SKIP_ON_SHUTDOWN. Note that the default shutdown behavior is BLOCK_SHUTDOWN in SequencedWorkerPool and SKIP_ON_SHUTDOWN in TaskScheduler. What if the task priority is not set explicitly (no base::TaskPriority)? When there is no explicit priority, the priority is inherited from the calling context (e.g. a task posted from a BACKGROUND task without an explicit priority will have a BACKGROUND priority).
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Use TaskScheduler instead of SequencedWorkerPool in cookie_util.mm. SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 R=droger@chromium.org ========== to ========== Use TaskScheduler instead of SequencedWorkerPool in cookie_util.mm. SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 R=droger@chromium.org ==========
fdoray@chromium.org changed reviewers: + rohitrao@chromium.org
On 2017/05/12 17:41:39, fdoray wrote: > Please take a look. > > This CL was generated automatically. > > The base::MayBlock() trait was specified for all call sites and the > base::TaskPriority::BACKGROUND trait was specified for all non-test call sites. > That may not be appropriate for your use case. > > Please verify that appropriate traits were used > https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h > If everything looks good, lgtm and CQ this CL. Otherwise, tell us what's wrong. > > Thanks. > > - FAQ - > > What if bots are red? Ignore this CL. A human will look at errors shortly. > > What if the shutdown behavior is not set explicitly (no > base::TaskShutdownBehavior)? > If shutdown behavior is important for a task, it should be set explicitly. > It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or > SKIP_ON_SHUTDOWN. Note that the default shutdown behavior is BLOCK_SHUTDOWN in > SequencedWorkerPool and SKIP_ON_SHUTDOWN in TaskScheduler. > > What if the task priority is not set explicitly (no base::TaskPriority)? > When there is no explicit priority, the priority is inherited from the > calling context (e.g. a task posted from a BACKGROUND task without an > explicit priority will have a BACKGROUND priority). +rohitrao@chromium.org (no reply from droger in 1 week)
lgtm
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1495486588665810, "parent_rev": "8c780e9d6bd5a1917f99c6daa4b9d0b1d258e2f5", "commit_rev": "b4ee2b4a14244ae634817e234a3c911c0cf5a099"}
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of SequencedWorkerPool in cookie_util.mm. SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 R=droger@chromium.org ========== to ========== Use TaskScheduler instead of SequencedWorkerPool in cookie_util.mm. SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 R=droger@chromium.org Review-Url: https://codereview.chromium.org/2878943002 Cr-Commit-Position: refs/heads/master@{#473694} Committed: https://chromium.googlesource.com/chromium/src/+/b4ee2b4a14244ae634817e234a3c... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b4ee2b4a14244ae634817e234a3c... |