Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2875553003: Add support for building v8 on mips and mips64 using GN. (Closed)

Created:
3 years, 7 months ago by sreten.kovacevic
Modified:
3 years, 6 months ago
CC:
chromium-reviews, v8-mips-ports_googlegroups.com, gordana.cmiljanovic_imgtec.com
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : added cflags and removed nacl mips definition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -6 lines) Patch
M build/build_config.h View 1 chunk +12 lines, -0 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 1 chunk +2 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 4 chunks +58 lines, -2 lines 0 comments Download
M build/config/mips.gni View 2 chunks +4 lines, -2 lines 0 comments Download
M build/config/sysroot.gni View 1 chunk +2 lines, -1 line 0 comments Download
M build/toolchain/linux/BUILD.gn View 3 chunks +48 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (13 generated)
Dirk Pranke
lgtm
3 years, 7 months ago (2017-05-11 02:24:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875553003/20001
3 years, 7 months ago (2017-05-15 09:05:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/436703)
3 years, 7 months ago (2017-05-15 09:14:32 UTC) #7
sreten.kovacevic
Hello, I need lgtm from owner of: build/config/BUILDCONFIG.gn
3 years, 7 months ago (2017-05-15 09:21:38 UTC) #8
Michael Achenbach
On 2017/05/15 09:21:38, sreten.kovacevic wrote: > Hello, I need lgtm from owner of: > build/config/BUILDCONFIG.gn ...
3 years, 7 months ago (2017-05-15 11:42:56 UTC) #9
brettw
Do you mind waiting a few days on this? A bunch of similar ones came ...
3 years, 7 months ago (2017-05-15 21:01:03 UTC) #10
sreten.kovacevic
On 2017/05/15 21:01:03, brettw wrote: > Do you mind waiting a few days on this? ...
3 years, 7 months ago (2017-05-26 11:39:32 UTC) #11
brettw
LGTM. Sorry for the delay. The policy document isn't ready yet but I think everybody ...
3 years, 6 months ago (2017-05-30 04:05:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875553003/20001
3 years, 6 months ago (2017-05-30 09:12:33 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/226023)
3 years, 6 months ago (2017-05-30 10:57:59 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875553003/20001
3 years, 6 months ago (2017-05-30 12:54:01 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4ba1f2ad0e20e132f082222ebcc53f1bf870a42d
3 years, 6 months ago (2017-05-30 12:57:58 UTC) #25
brettw
Here's the policy which should hopefully be unsurprising: https://chromium.googlesource.com/chromium/src/+/master/docs/new_port_policy.md
3 years, 6 months ago (2017-05-31 17:00:42 UTC) #26
ivica.bogosavljevic
On 2017/05/31 17:00:42, brettw wrote: > Here's the policy which should hopefully be unsurprising: > ...
3 years, 6 months ago (2017-06-05 13:33:29 UTC) #27
brettw
3 years, 6 months ago (2017-06-05 17:59:10 UTC) #28
Message was sent while issue was closed.
On 2017/06/05 13:33:29, ivica.bogosavljevic wrote:
> On 2017/05/31 17:00:42, brettw wrote:
> > Here's the policy which should hopefully be unsurprising:
> > 
> >
>
https://chromium.googlesource.com/chromium/src/+/master/docs/new_port_policy.md
> 
> V8 for MIPS big-endian was compiling using GYP for very long time. But in
order
> to support
> compilation using GN, we need to add some modifications to GN files which are
> part of Chromium
> thereby introducing big-endian Chromium port.
> 
> We don't plan to support Chromium on MIPS big-endian, but we do plan to
support
> V8 on
> MIPS big-endian. Please advise us what to do.

I think the current state is fine and you don't need to do anything.

Powered by Google App Engine
This is Rietveld 408576698