|
|
Created:
3 years, 7 months ago by fdoray Modified:
3 years, 7 months ago CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed) Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse TaskScheduler instead of SequencedWorkerPool in application_context_impl.cc.
SequencedWorkerPool is being deprecated in favor of TaskScheduler.
BUG=667892
R=droger@chromium.org
Review-Url: https://codereview.chromium.org/2875353005
Cr-Commit-Position: refs/heads/master@{#473882}
Committed: https://chromium.googlesource.com/chromium/src/+/356900781422ed59137ca54d171adda3890d8870
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 24 (15 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Please take a look. This CL was generated automatically. The base::MayBlock() trait was specified for all call sites and the base::TaskPriority::BACKGROUND trait was specified for all non-test call sites. That may not be appropriate for your use case. Please verify that appropriate traits were used https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h If everything looks good, lgtm and CQ this CL. Otherwise, tell us what's wrong. Thanks. - FAQ - What if bots are red? Ignore this CL. A human will look at errors shortly. What if the shutdown behavior is not set explicitly (no base::TaskShutdownBehavior)? If shutdown behavior is important for a task, it should be set explicitly. It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or SKIP_ON_SHUTDOWN. Note that the default shutdown behavior is BLOCK_SHUTDOWN in SequencedWorkerPool and SKIP_ON_SHUTDOWN in TaskScheduler. What if the task priority is not set explicitly (no base::TaskPriority)? When there is no explicit priority, the priority is inherited from the calling context (e.g. a task posted from a BACKGROUND task without an explicit priority will have a BACKGROUND priority).
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Use TaskScheduler instead of SequencedWorkerPool in application_context_impl.cc. SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 R=droger@chromium.org ========== to ========== Use TaskScheduler instead of SequencedWorkerPool in application_context_impl.cc. SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 R=droger@chromium.org ==========
fdoray@chromium.org changed reviewers: + rohitrao@chromium.org
On 2017/05/12 17:37:56, fdoray wrote: > Please take a look. > > This CL was generated automatically. > > The base::MayBlock() trait was specified for all call sites and the > base::TaskPriority::BACKGROUND trait was specified for all non-test call sites. > That may not be appropriate for your use case. > > Please verify that appropriate traits were used > https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h > If everything looks good, lgtm and CQ this CL. Otherwise, tell us what's wrong. > > Thanks. > > - FAQ - > > What if bots are red? Ignore this CL. A human will look at errors shortly. > > What if the shutdown behavior is not set explicitly (no > base::TaskShutdownBehavior)? > If shutdown behavior is important for a task, it should be set explicitly. > It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or > SKIP_ON_SHUTDOWN. Note that the default shutdown behavior is BLOCK_SHUTDOWN in > SequencedWorkerPool and SKIP_ON_SHUTDOWN in TaskScheduler. > > What if the task priority is not set explicitly (no base::TaskPriority)? > When there is no explicit priority, the priority is inherited from the > calling context (e.g. a task posted from a BACKGROUND task without an > explicit priority will have a BACKGROUND priority). +rohitrao@chromium.org (no reply from droger in 1 week)
On 2017/05/19 19:14:54, fdoray wrote: > On 2017/05/12 17:37:56, fdoray wrote: > > Please take a look. > > > > This CL was generated automatically. > > > > The base::MayBlock() trait was specified for all call sites and the > > base::TaskPriority::BACKGROUND trait was specified for all non-test call > sites. > > That may not be appropriate for your use case. > > > > Please verify that appropriate traits were used > > https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h > > If everything looks good, lgtm and CQ this CL. Otherwise, tell us what's > wrong. > > > > Thanks. > > > > - FAQ - > > > > What if bots are red? Ignore this CL. A human will look at errors shortly. > > > > What if the shutdown behavior is not set explicitly (no > > base::TaskShutdownBehavior)? > > If shutdown behavior is important for a task, it should be set explicitly. > > It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or > > SKIP_ON_SHUTDOWN. Note that the default shutdown behavior is BLOCK_SHUTDOWN in > > SequencedWorkerPool and SKIP_ON_SHUTDOWN in TaskScheduler. > > > > What if the task priority is not set explicitly (no base::TaskPriority)? > > When there is no explicit priority, the priority is inherited from the > > calling context (e.g. a task posted from a BACKGROUND task without an > > explicit priority will have a BACKGROUND priority). > > mailto:+rohitrao@chromium.org (no reply from droger in 1 week) droger is OOO till beginning of June so you may want to find a new OWNERS for any review you've sent to droger.
lgtm
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by fdoray@chromium.org
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rohitrao@chromium.org Link to the patchset: https://codereview.chromium.org/2875353005/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495547532472330, "parent_rev": "02fd70ff6d79411e5e5c503bd83a79453da76fb7", "commit_rev": "356900781422ed59137ca54d171adda3890d8870"}
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of SequencedWorkerPool in application_context_impl.cc. SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 R=droger@chromium.org ========== to ========== Use TaskScheduler instead of SequencedWorkerPool in application_context_impl.cc. SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 R=droger@chromium.org Review-Url: https://codereview.chromium.org/2875353005 Cr-Commit-Position: refs/heads/master@{#473882} Committed: https://chromium.googlesource.com/chromium/src/+/356900781422ed59137ca54d171a... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/356900781422ed59137ca54d171a... |