Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2856493002: [Merge to M59] cros: Update virtual audio label name to Built-in mic/speaker (Closed)

Created:
3 years, 7 months ago by Qiang(Joe) Xu
Modified:
3 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Merge to M59] cros: Update virtual audio label name to Built-in mic/speaker Changes: As from discussion with UX writer, updating the label name here. TBR=tommi@chromium.org BUG=658048 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2847173003 Cr-Commit-Position: refs/heads/master@{#468248} (cherry picked from commit 934e8926ee432fe5f5e6b2b9a1f196455ede77df) Review-Url: https://codereview.chromium.org/2856493002 . Cr-Commit-Position: refs/branch-heads/3071@{#314} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/58a885b06af608a8dd427e81a490ef5fb8cc0e2d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/audio/cras/audio_manager_cras.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Qiang(Joe) Xu
3 years, 7 months ago (2017-05-01 00:33:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58a885b06af608a8dd427e81a490ef5fb8cc0e2d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698