Forward BrowserAccessibilityWin::get_accKeyboardShortcut to the platform node

Forward BrowserAccessibilityWin::get_accKeyboardShortcut to the platform node

BUG=703369
Review-Url: https://codereview.chromium.org/2849063002
Cr-Commit-Position: refs/heads/master@{#478896}
Committed: https://chromium.googlesource.com/chromium/src/+/317b0a78cf083a14fcf59871e03ca049fac2822d

[dougt, 2017-04-30 04:54:08]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-30 04:54:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-30 05:44:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-30 05:44:40]

Dry run: This issue passed the CQ dry run.

[dougt, 2017-04-30 06:15:27]

dougt@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2017-05-01 16:15:25]

Please update ax_platform_node_win_unittest.cc,
we already have a test for this attribute.

Actually I think I'd be happy to merge KEY_SHORTCUTS
and SHORTCUT, they're both pretty obscure and we
don't really need both. Want to do that in the same
change or file a bug as a follow-up? If you do that
the test won't need to be changed.

[dougt, 2017-05-31 23:35:36]

dI am not sure this is the right approach, but here we remove the
AX_ATTR_SHORTCUT all together

[dougt, 2017-05-31 23:38:20]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 23:39:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 01:15:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 01:15:21]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-06-06 04:44:17]

lgtm

https://codereview.chromium.org/2849063002/diff/20001/content/renderer/access...
File content/renderer/accessibility/blink_ax_tree_source.cc (right):

https://codereview.chromium.org/2849063002/diff/20001/content/renderer/access...
content/renderer/accessibility/blink_ax_tree_source.cc:564: if
(src.KeyboardShortcut().length()) {
Note that AX_ATTR_KEY_SHORTCUTS may already be set above, in
GetSparseAXAttributes.

Let's skip this one if that one already set that attribute. Change this to:

if (src.KeyboardShortcut().length() &&
!dst->HasStringAttribute(ui::AX_ATTR_KEY_SHORTCUTS))

[dougt, 2017-06-13 01:46:26]

dougt@chromium.org changed reviewers:
+ pkasting@chromium.org

[dougt, 2017-06-13 01:46:26]

pkasting, ptal.

[Peter Kasting, 2017-06-13 02:32:57]

On 2017/06/13 01:46:26, dougt wrote:
> pkasting, ptal.

c/b/ui/views/infobars LGTM.  Were you asking for more review than that?  If
possible, always say which files you want reviewers looking at when there is
more than one reviewer.

[dougt, 2017-06-13 02:42:26]

The CQ bit was checked by dougt@chromium.org

[dougt, 2017-06-13 02:42:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2849063002/#ps60001
(title: "Add has check to ensure we don't override key shortcut")

[chromium-reviews, 2017-06-13 02:42:48]

Understood.  Thank you for the review Peter.

On Mon, Jun 12, 2017 at 7:32 PM, <pkasting@chromium.org> wrote:

> On 2017/06/13 01:46:26, dougt wrote:
> > pkasting, ptal.
>
> c/b/ui/views/infobars LGTM. Were you asking for more review than that? If
> possible, always say which files you want reviewers looking at when there
> is
> more than one reviewer.
>
> https://codereview.chromium.org/2849063002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-06-13 02:42:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 04:04:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497321746454370,
"parent_rev": "f5ec8bec81e8f54e11e0367836294357dd99c915", "commit_rev":
"317b0a78cf083a14fcf59871e03ca049fac2822d"}

[commit-bot: I haz the power, 2017-06-13 04:04:54]

Description was changed from

==========
Forward BrowserAccessibilityWin::get_accKeyboardShortcut to the platform node

BUG=703369
==========

to

==========
Forward BrowserAccessibilityWin::get_accKeyboardShortcut to the platform node

BUG=703369

Review-Url: https://codereview.chromium.org/2849063002
Cr-Commit-Position: refs/heads/master@{#478896}
Committed:
https://chromium.googlesource.com/chromium/src/+/317b0a78cf083a14fcf59871e03c...
==========

[commit-bot: I haz the power, 2017-06-13 04:04:59]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/317b0a78cf083a14fcf59871e03c...