Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2848183002: wpt-import: Fix a failure on "git add" (Closed)

Created:
3 years, 7 months ago by tkent
Modified:
3 years, 7 months ago
Reviewers:
qyearsley, jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

wpt-import: Fix a failure on "git add" This CL fixes a regression since r467828. It changed the working directory, but it missed to update relative path in "git add" argument. BUG=710535 TBR=jeffcarp@chromium.org NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
tkent
3 years, 7 months ago (2017-05-01 00:26:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848183002/1
3 years, 7 months ago (2017-05-01 00:26:43 UTC) #4
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 7 months ago (2017-05-01 00:32:31 UTC) #7
jeffcarp
lgtm
3 years, 7 months ago (2017-05-01 17:35:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848183002/1
3 years, 7 months ago (2017-05-01 17:36:36 UTC) #10
jeffcarp
On 2017/05/01 at 17:35:56, jeffcarp wrote: > lgtm Thank you!
3 years, 7 months ago (2017-05-01 17:36:39 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/424438)
3 years, 7 months ago (2017-05-01 17:46:22 UTC) #13
jeffcarp
On 2017/05/01 at 17:46:22, commit-bot wrote: > Try jobs failed on following builders: > chromium_presubmit ...
3 years, 7 months ago (2017-05-01 18:21:24 UTC) #14
jeffcarp
On 2017/05/01 at 18:21:24, jeffcarp wrote: > On 2017/05/01 at 17:46:22, commit-bot wrote: > > ...
3 years, 7 months ago (2017-05-01 21:38:48 UTC) #15
qyearsley
3 years, 7 months ago (2017-05-08 17:04:38 UTC) #17
From Rietveld, it appears like this wasn't committed, but actually it was:
https://chromium.googlesource.com/chromium/src/+/9b549cec866068f02af088ed0eec....

Closing since it's actually committed...

Also, LGTM, thanks

Powered by Google App Engine
This is Rietveld 408576698