|
|
Descriptionwpt-import: Fix a failure on "git add"
This CL fixes a regression since r467828. It changed the working directory, but
it missed to update relative path in "git add" argument.
BUG=710535
TBR=jeffcarp@chromium.org
NOTRY=true
Patch Set 1 #
Messages
Total messages: 17 (7 generated)
Description was changed from ========== wpt-import: Fix a fail on "git add" This CL fixes a regression since r467828. It changed the working directory, but it missed to udpate relative path in "git add" argument. BUG=710535 TBR=jeffcarp@chromium.org NOTRY=true ========== to ========== wpt-import: Fix a failure on "git add" This CL fixes a regression since r467828. It changed the working directory, but it missed to update relative path in "git add" argument. BUG=710535 TBR=jeffcarp@chromium.org NOTRY=true ==========
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1493598397913670, "parent_rev": "6c14f269fb196627c72a810205488d694b63a7d5", "commit_rev": "9b549cec866068f02af088ed0eec0efea26cb150"}
The CQ bit was unchecked by commit-bot@chromium.org
Prior attempt to commit was detected, but we were not able to check whether the issue was successfully committed. Please check Git history manually and re-check CQ or close this issue as needed.
The CQ bit was checked by jeffcarp@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/05/01 at 17:35:56, jeffcarp wrote: > lgtm Thank you!
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2017/05/01 at 17:46:22, commit-bot wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) It looks like there are presubmit errors but I'm having a hard time diagnosing exactly what's wrong. There's this log line: @@@STEP_LOG_LINE@reason@Step('commit-git-patch') failed with return_code 1@@@ But I can't find anything further than that
On 2017/05/01 at 18:21:24, jeffcarp wrote: > On 2017/05/01 at 17:46:22, commit-bot wrote: > > Try jobs failed on following builders: > > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) > > It looks like there are presubmit errors but I'm having a hard time diagnosing exactly what's wrong. There's this log line: > @@@STEP_LOG_LINE@reason@Step('commit-git-patch') failed with return_code 1@@@ > > But I can't find anything further than that Omg I'm an idiot - just saw that this was TBR'd. Thanks for fixing!
qyearsley@chromium.org changed reviewers: + qyearsley@chromium.org
From Rietveld, it appears like this wasn't committed, but actually it was: https://chromium.googlesource.com/chromium/src/+/9b549cec866068f02af088ed0eec.... Closing since it's actually committed... Also, LGTM, thanks |