Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2846703004: Exclude crash tests for O (Closed)

Created:
3 years, 7 months ago by Shimi Zhang
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Exclude crash tests for O BUG=714672 Review-Url: https://codereview.chromium.org/2846703004 Cr-Commit-Position: refs/heads/master@{#468253} Committed: https://chromium.googlesource.com/chromium/src/+/ef4a5d5cee27a964cdfbe498ae71a93761b78b5b

Patch Set 1 #

Patch Set 2 : Add documentation for later on cleanup #

Total comments: 2

Patch Set 3 : Rephrase comments #

Total comments: 1

Patch Set 4 : nits #

Patch Set 5 : use android_sdk_version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/android/BUILD.gn View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnableTest.java View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 43 (20 generated)
Shimi Zhang
Just Exclude crush tests for O, then we need to bring them back when O ...
3 years, 7 months ago (2017-04-27 21:42:28 UTC) #4
gone
So does this mean the other two CLs won't land?
3 years, 7 months ago (2017-04-27 21:43:10 UTC) #5
Shimi Zhang
On 2017/04/27 21:43:10, slow (dfalcantara) wrote: > So does this mean the other two CLs ...
3 years, 7 months ago (2017-04-27 21:45:41 UTC) #6
gone
I'll defer to the folks who are most familiar with the build system then.
3 years, 7 months ago (2017-04-27 21:47:30 UTC) #7
Ilya Sherman
Hmm, I'm a bit worried that we'll forget about this and lose test coverage; I'd ...
3 years, 7 months ago (2017-04-27 21:53:37 UTC) #8
Shimi Zhang
On 2017/04/27 21:53:37, Ilya Sherman wrote: > Hmm, I'm a bit worried that we'll forget ...
3 years, 7 months ago (2017-04-27 21:57:53 UTC) #10
Ilya Sherman
On 2017/04/27 21:57:53, Shimi Zhang wrote: > On 2017/04/27 21:53:37, Ilya Sherman wrote: > > ...
3 years, 7 months ago (2017-04-27 21:59:56 UTC) #11
sgurun-gerrit only
On 2017/04/27 21:59:56, Ilya Sherman wrote: > On 2017/04/27 21:57:53, Shimi Zhang wrote: > > ...
3 years, 7 months ago (2017-04-27 22:18:01 UTC) #12
Shimi Zhang
On 2017/04/27 22:18:01, sgurun wrote: > On 2017/04/27 21:59:56, Ilya Sherman wrote: > > On ...
3 years, 7 months ago (2017-04-27 22:33:58 UTC) #13
sgurun-gerrit only
On 2017/04/27 22:33:58, Shimi Zhang wrote: > On 2017/04/27 22:18:01, sgurun wrote: > > On ...
3 years, 7 months ago (2017-04-27 22:49:20 UTC) #14
Ilya Sherman
LGTM % a comment about phrasing, assuming that this is the preferred solution by folks ...
3 years, 7 months ago (2017-04-27 23:35:38 UTC) #15
Shimi Zhang
https://codereview.chromium.org/2846703004/diff/20001/chrome/android/BUILD.gn File chrome/android/BUILD.gn (right): https://codereview.chromium.org/2846703004/diff/20001/chrome/android/BUILD.gn#newcode415 chrome/android/BUILD.gn:415: # TODO(crbug/716236): Remove it and update those two files ...
3 years, 7 months ago (2017-04-28 00:54:46 UTC) #16
agrieve
just a nit build-wise lgtm https://codereview.chromium.org/2846703004/diff/40001/chrome/android/BUILD.gn File chrome/android/BUILD.gn (right): https://codereview.chromium.org/2846703004/diff/40001/chrome/android/BUILD.gn#newcode417 chrome/android/BUILD.gn:417: if (defined(use_really_unpublished_apis) && use_really_unpublished_apis) ...
3 years, 7 months ago (2017-04-28 01:05:33 UTC) #17
Shimi Zhang
On 2017/04/28 01:05:33, agrieve wrote: > just a nit build-wise lgtm > > https://codereview.chromium.org/2846703004/diff/40001/chrome/android/BUILD.gn > ...
3 years, 7 months ago (2017-04-28 17:27:29 UTC) #20
Shimi Zhang
On 2017/04/28 17:27:29, Shimi Zhang wrote: > On 2017/04/28 01:05:33, agrieve wrote: > > just ...
3 years, 7 months ago (2017-04-28 18:04:56 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846703004/80001
3 years, 7 months ago (2017-04-28 21:48:14 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/423732)
3 years, 7 months ago (2017-04-28 21:58:46 UTC) #32
Shimi Zhang
dfalcantara@, could you please check those two test files, forgot to ask file owner to ...
3 years, 7 months ago (2017-04-28 22:14:35 UTC) #33
gone
lgtm
3 years, 7 months ago (2017-04-30 02:05:23 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846703004/80001
3 years, 7 months ago (2017-04-30 03:49:41 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/442077)
3 years, 7 months ago (2017-04-30 04:52:09 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846703004/80001
3 years, 7 months ago (2017-04-30 05:39:01 UTC) #40
commit-bot: I haz the power
3 years, 7 months ago (2017-04-30 07:04:09 UTC) #43
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/ef4a5d5cee27a964cdfbe498ae71...

Powered by Google App Engine
This is Rietveld 408576698