Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2845303003: added rounded corners & created file for rounded corners (Closed)

Created:
3 years, 7 months ago by injae
Modified:
3 years, 7 months ago
Reviewers:
Daniel Park, gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

added rounded corners & created file for rounded corners BUG=655359 Review-Url: https://codereview.chromium.org/2845303003 Cr-Commit-Position: refs/heads/master@{#468718} Committed: https://chromium.googlesource.com/chromium/src/+/bf01bb382257c6e6a98275cdf265d115eb98e9fb

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments #

Patch Set 3 : fixing Link context menu's header color #

Total comments: 5

Patch Set 4 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
A chrome/android/java/res/drawable/white_with_rounded_corners.xml View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/android/java/res/layout/tabular_context_menu_page.xml View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java View 1 2 3 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 15 (4 generated)
Daniel Park
3 years, 7 months ago (2017-04-28 23:25:24 UTC) #2
gone
This doesn't deal with the tablayout's gray background, right? https://codereview.chromium.org/2845303003/diff/1/chrome/android/java/res/drawable/white_with_rounded_corners.xml File chrome/android/java/res/drawable/white_with_rounded_corners.xml (right): https://codereview.chromium.org/2845303003/diff/1/chrome/android/java/res/drawable/white_with_rounded_corners.xml#newcode1 chrome/android/java/res/drawable/white_with_rounded_corners.xml:1: ...
3 years, 7 months ago (2017-04-30 02:14:45 UTC) #3
Daniel Park
On 2017/04/30 02:14:45, slow (dfalcantara) wrote: > This doesn't deal with the tablayout's gray background, ...
3 years, 7 months ago (2017-05-01 17:29:23 UTC) #4
Daniel Park
https://codereview.chromium.org/2845303003/diff/1/chrome/android/java/res/drawable/white_with_rounded_corners.xml File chrome/android/java/res/drawable/white_with_rounded_corners.xml (right): https://codereview.chromium.org/2845303003/diff/1/chrome/android/java/res/drawable/white_with_rounded_corners.xml#newcode1 chrome/android/java/res/drawable/white_with_rounded_corners.xml:1: <?xml version="1.0" encoding="utf-8"?> On 2017/04/30 02:14:45, slow (dfalcantara) wrote: ...
3 years, 7 months ago (2017-05-01 17:30:10 UTC) #5
gone
Screenshots on the bug for posterity, otherwise lgtm.
3 years, 7 months ago (2017-05-01 17:30:51 UTC) #6
Daniel Park
fixed the grey not appearing on the header for "Link" context menu
3 years, 7 months ago (2017-05-02 17:05:32 UTC) #7
gone
https://codereview.chromium.org/2845303003/diff/40001/chrome/android/java/res/drawable/white_with_rounded_corners.xml File chrome/android/java/res/drawable/white_with_rounded_corners.xml (right): https://codereview.chromium.org/2845303003/diff/40001/chrome/android/java/res/drawable/white_with_rounded_corners.xml#newcode2 chrome/android/java/res/drawable/white_with_rounded_corners.xml:2: <!-- Copyright 2016 The Chromium Authors. All rights reserved. ...
3 years, 7 months ago (2017-05-02 17:09:39 UTC) #8
Daniel Park
https://codereview.chromium.org/2845303003/diff/40001/chrome/android/java/res/drawable/white_with_rounded_corners.xml File chrome/android/java/res/drawable/white_with_rounded_corners.xml (right): https://codereview.chromium.org/2845303003/diff/40001/chrome/android/java/res/drawable/white_with_rounded_corners.xml#newcode2 chrome/android/java/res/drawable/white_with_rounded_corners.xml:2: <!-- Copyright 2016 The Chromium Authors. All rights reserved. ...
3 years, 7 months ago (2017-05-02 17:46:56 UTC) #9
gone
lgtm
3 years, 7 months ago (2017-05-02 17:47:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845303003/60001
3 years, 7 months ago (2017-05-02 17:53:19 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 18:48:44 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bf01bb382257c6e6a98275cdf265...

Powered by Google App Engine
This is Rietveld 408576698