third_party/WebKit/Source/core/animation/ListInterpolationFunctions.h - Issue 2844213002: Fix behaviour of shadow interpolation with mismatched list lengths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/ListInterpolationFunctions.h

Issue 2844213002: Fix behaviour of shadow interpolation with mismatched list lengths (Closed)

Patch Set: Revert transition test to old behaviour Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSSizeListInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/ListInterpolationFunctions.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/ListInterpolationFunctions.h

diff --git a/third_party/WebKit/Source/core/animation/ListInterpolationFunctions.h b/third_party/WebKit/Source/core/animation/ListInterpolationFunctions.h

index 8e1fe604b7deaf49dd15b20c68dac0df3d4f0933..9e868cbfb0b7a5e312516f52e6b8fab385d8fdc1 100644

--- a/third_party/WebKit/Source/core/animation/ListInterpolationFunctions.h

+++ b/third_party/WebKit/Source/core/animation/ListInterpolationFunctions.h

@@ -23,12 +23,15 @@ class ListInterpolationFunctions {

return InterpolationValue(InterpolableList::Create(0));

}

+ enum class LengthMatchingStrategy { kLowestCommonMultiple, kPadToLargest };

using MergeSingleItemConversionsCallback =

PairwiseInterpolationValue (*)(InterpolationValue&& start,

InterpolationValue&& end);

static PairwiseInterpolationValue MaybeMergeSingles(

InterpolationValue&& start,

InterpolationValue&& end,

+ LengthMatchingStrategy,

MergeSingleItemConversionsCallback);

using EqualNonInterpolableValuesCallback =

@@ -48,6 +51,7 @@ class ListInterpolationFunctions {

double underlying_fraction,

const InterpolationType&,

const InterpolationValue&,

+ LengthMatchingStrategy,

NonInterpolableValuesAreCompatibleCallback,

CompositeItemCallback);

};