Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2842943002:
🔍 PromoDialog tests (Closed)
Description🔍 PromoDialog tests
Add a bunch of basic tests for the PromoDialog/PromoDialogLayout
that confirm that elements appear when they should, and that
clicking on them triggers the right events.
BUG=712836, 712833
Review-Url: https://codereview.chromium.org/2842943002
Cr-Commit-Position: refs/heads/master@{#467590}
Committed: https://chromium.googlesource.com/chromium/src/+/36aa8d683c4bd21613115a08de2c3aff69abcda0
Patch Set 1 #
Total comments: 1
Patch Set 2 : Moved stuff backward #Patch Set 3 : 🔍 PromoDialog tests #Patch Set 4 : rebase #Patch Set 5 : Rebased #Patch Set 6 : 🔍 PromoDialog tests #Patch Set 7 : 🔍 PromoDialog tests #Patch Set 8 : ugh rebasing #
Messages
Total messages: 27 (18 generated)
The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dfalcantara@chromium.org changed reviewers: + twellington@chromium.org
Adding tests to an existing class. PTAL when you get a chance. https://codereview.chromium.org/2842943002/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/widget/PromoDialogLayout.java (right): https://codereview.chromium.org/2842943002/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/widget/PromoDialogLayout.java:24: * specific behaviors (see go/snowflake-dialogs for details): Not entirely sure if it makes sense to link to the internal design doc, here. WDYT?
Description was changed from ========== 🔍 PromoDialog tests * Add a bunch of basic tests for the PromoDialog/PromoDialogLayout. * Add some clarifying comments to the PromoDialogLayout. BUG=712836,712833 ========== to ========== 🔍 PromoDialog tests Add a bunch of basic tests for the PromoDialog/PromoDialogLayout that confirm that elements appear when they should, and that clicking on them triggers the right events. BUG=712836,712833 ==========
On 2017/04/26 05:11:48, slow (dfalcantara) wrote: > Adding tests to an existing class. PTAL when you get a chance. > > https://codereview.chromium.org/2842943002/diff/1/chrome/android/java/src/org... > File > chrome/android/java/src/org/chromium/chrome/browser/widget/PromoDialogLayout.java > (right): > > https://codereview.chromium.org/2842943002/diff/1/chrome/android/java/src/org... > chrome/android/java/src/org/chromium/chrome/browser/widget/PromoDialogLayout.java:24: > * specific behaviors (see go/snowflake-dialogs for details): > Not entirely sure if it makes sense to link to the internal design doc, here. > WDYT? Ignore that; moved it back to the previous CL.
lgtm
The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dfalcantara@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from twellington@chromium.org Link to the patchset: https://codereview.chromium.org/2842943002/#ps100001 (title: "🔍 PromoDialog tests")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by dfalcantara@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from twellington@chromium.org Link to the patchset: https://codereview.chromium.org/2842943002/#ps120001 (title: "🔍 PromoDialog tests")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by dfalcantara@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from twellington@chromium.org Link to the patchset: https://codereview.chromium.org/2842943002/#ps140001 (title: "ugh rebasing")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 140001, "attempt_start_ts": 1493263118304830,
"parent_rev": "a3113f3049092c40df4181b98e960785eaadcfb9", "commit_rev":
"36aa8d683c4bd21613115a08de2c3aff69abcda0"}
Message was sent while issue was closed.
Description was changed from ========== 🔍 PromoDialog tests Add a bunch of basic tests for the PromoDialog/PromoDialogLayout that confirm that elements appear when they should, and that clicking on them triggers the right events. BUG=712836,712833 ========== to ========== 🔍 PromoDialog tests Add a bunch of basic tests for the PromoDialog/PromoDialogLayout that confirm that elements appear when they should, and that clicking on them triggers the right events. BUG=712836,712833 Review-Url: https://codereview.chromium.org/2842943002 Cr-Commit-Position: refs/heads/master@{#467590} Committed: https://chromium.googlesource.com/chromium/src/+/36aa8d683c4bd21613115a08de2c... ==========
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as https://chromium.googlesource.com/chromium/src/+/36aa8d683c4bd21613115a08de2c... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
