Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 2837583004: [Remoting Host] Add more codec spec information for VP9 (Closed)

Created:
3 years, 8 months ago by Yuwei
Modified:
3 years, 8 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, posciak+watch_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remoting Host] Add more codec spec information for VP9 The Android hardware decoder can't properly decode the desktop if the codec spec is not properly set. This fix is only for VP9 I420. I444 hardware decoding codepath is still broken. BUG=706220 Review-Url: https://codereview.chromium.org/2837583004 Cr-Commit-Position: refs/heads/master@{#466720} Committed: https://chromium.googlesource.com/chromium/src/+/7961ed28c4513ca0415a28720ff43a5109794f23

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M remoting/protocol/webrtc_dummy_video_encoder.cc View 1 1 chunk +21 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Yuwei
PTAL
3 years, 8 months ago (2017-04-21 22:36:27 UTC) #3
Sergey Ulanov
lgtm https://codereview.chromium.org/2837583004/diff/1/remoting/protocol/webrtc_dummy_video_encoder.cc File remoting/protocol/webrtc_dummy_video_encoder.cc (right): https://codereview.chromium.org/2837583004/diff/1/remoting/protocol/webrtc_dummy_video_encoder.cc#newcode136 remoting/protocol/webrtc_dummy_video_encoder.cc:136: webrtc::CodecSpecificInfoVP9* vp9_info = maybe add vp8_info for VP8 ...
3 years, 8 months ago (2017-04-24 17:11:35 UTC) #4
Yuwei
Thanks! https://codereview.chromium.org/2837583004/diff/1/remoting/protocol/webrtc_dummy_video_encoder.cc File remoting/protocol/webrtc_dummy_video_encoder.cc (right): https://codereview.chromium.org/2837583004/diff/1/remoting/protocol/webrtc_dummy_video_encoder.cc#newcode136 remoting/protocol/webrtc_dummy_video_encoder.cc:136: webrtc::CodecSpecificInfoVP9* vp9_info = On 2017/04/24 17:11:35, Sergey Ulanov ...
3 years, 8 months ago (2017-04-24 19:13:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837583004/20001
3 years, 8 months ago (2017-04-24 19:14:36 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 19:44:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7961ed28c4513ca0415a28720ff4...

Powered by Google App Engine
This is Rietveld 408576698