Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2741)

Unified Diff: chrome/android/java/res/layout/search_widget_template.xml

Issue 2837503003: 🔍 Make the widget taller and usable on all channels (Closed)
Patch Set: 🔍 Make the widget taller and usable on all channels Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/AndroidManifest.xml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/search_widget_template.xml
diff --git a/chrome/android/java/res/layout/search_widget_template.xml b/chrome/android/java/res/layout/search_widget_template.xml
index 59e3ec29a858520b8f70ac4638e7dbc30756a9ec..56db3421d234db645f192627a3252ec24346ff37 100644
--- a/chrome/android/java/res/layout/search_widget_template.xml
+++ b/chrome/android/java/res/layout/search_widget_template.xml
@@ -5,13 +5,8 @@
<!-- NOTES ON SPEC IMPLEMENTATION:
+................................................................+
- 42dp | STRING TO SHOW MIC |
+ 48dp | STRING TO SHOW MIC |
+................................................................+
-
- The microphone icon is supposed to be 24dp x 24dp. To allow a bigger
- touch target, we make it 42dp by adding 9dp of padding to each side.
- Because there is supposed to be a 12dp in between the microphone and
- the box, we use a total of 12dp for the end padding.
-->
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
@@ -24,10 +19,13 @@
android:gravity="center_vertical"
android:orientation="horizontal" >
+ <!-- The 12dp padding on the left comes from the fact that the microphone is 24dp x 24dp,
+ and sits in a 48dp x 48dp box. This means there's an implied 12dp of padding
+ around the entire microphone. -->
<TextView
android:id="@+id/title"
android:layout_width="0dp"
- android:layout_height="42dp"
+ android:layout_height="48dp"
android:layout_weight="1"
android:paddingStart="12dp"
android:gravity="center_vertical"
@@ -38,12 +36,8 @@
<ImageView
android:id="@+id/microphone_icon"
- android:layout_width="42dp"
- android:layout_height="42dp"
- android:paddingTop="9dp"
- android:paddingBottom="9dp"
- android:paddingStart="9dp"
- android:paddingEnd="12dp"
+ android:layout_width="48dp"
+ android:layout_height="48dp"
android:src="@drawable/infobar_microphone"
android:tint="@color/light_normal_color"
android:contentDescription="@null"
« no previous file with comments | « chrome/android/java/AndroidManifest.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698