Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1447)

Side by Side Diff: chrome/android/java/res/layout/search_widget_template.xml

Issue 2837503003: 🔍 Make the widget taller and usable on all channels (Closed)
Patch Set: 🔍 Make the widget taller and usable on all channels Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/java/AndroidManifest.xml ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2017 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <!-- NOTES ON SPEC IMPLEMENTATION: 6 <!-- NOTES ON SPEC IMPLEMENTATION:
7 +................................................................+ 7 +................................................................+
8 42dp | STRING TO SHOW MIC | 8 48dp | STRING TO SHOW MIC |
9 +................................................................+ 9 +................................................................+
10
11 The microphone icon is supposed to be 24dp x 24dp. To allow a bigger
12 touch target, we make it 42dp by adding 9dp of padding to each side.
13 Because there is supposed to be a 12dp in between the microphone and
14 the box, we use a total of 12dp for the end padding.
15 --> 10 -->
16 11
17 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" 12 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
18 android:id="@+id/text_container" 13 android:id="@+id/text_container"
19 android:layout_width="match_parent" 14 android:layout_width="match_parent"
20 android:layout_height="wrap_content" 15 android:layout_height="wrap_content"
21 android:layout_gravity="center" 16 android:layout_gravity="center"
22 android:alpha="0.9" 17 android:alpha="0.9"
23 android:background="@drawable/card_single" 18 android:background="@drawable/card_single"
24 android:gravity="center_vertical" 19 android:gravity="center_vertical"
25 android:orientation="horizontal" > 20 android:orientation="horizontal" >
26 21
22 <!-- The 12dp padding on the left comes from the fact that the microphone is 24dp x 24dp,
23 and sits in a 48dp x 48dp box. This means there's an implied 12dp of p adding
24 around the entire microphone. -->
27 <TextView 25 <TextView
28 android:id="@+id/title" 26 android:id="@+id/title"
29 android:layout_width="0dp" 27 android:layout_width="0dp"
30 android:layout_height="42dp" 28 android:layout_height="48dp"
31 android:layout_weight="1" 29 android:layout_weight="1"
32 android:paddingStart="12dp" 30 android:paddingStart="12dp"
33 android:gravity="center_vertical" 31 android:gravity="center_vertical"
34 android:singleLine="true" 32 android:singleLine="true"
35 android:textAlignment="viewStart" 33 android:textAlignment="viewStart"
36 android:textColor="@color/google_grey_600" 34 android:textColor="@color/google_grey_600"
37 android:textSize="17sp" /> 35 android:textSize="17sp" />
38 36
39 <ImageView 37 <ImageView
40 android:id="@+id/microphone_icon" 38 android:id="@+id/microphone_icon"
41 android:layout_width="42dp" 39 android:layout_width="48dp"
42 android:layout_height="42dp" 40 android:layout_height="48dp"
43 android:paddingTop="9dp"
44 android:paddingBottom="9dp"
45 android:paddingStart="9dp"
46 android:paddingEnd="12dp"
47 android:src="@drawable/infobar_microphone" 41 android:src="@drawable/infobar_microphone"
48 android:tint="@color/light_normal_color" 42 android:tint="@color/light_normal_color"
49 android:contentDescription="@null" 43 android:contentDescription="@null"
50 android:scaleType="centerInside" /> 44 android:scaleType="centerInside" />
51 45
52 </LinearLayout> 46 </LinearLayout>
OLDNEW
« no previous file with comments | « chrome/android/java/AndroidManifest.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698