Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2837503003: 🔍 Make the widget taller and usable on all channels (Closed)

Created:
3 years, 8 months ago by gone
Modified:
3 years, 8 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

🔍 Make the widget taller and usable on all channels * Increase the height of the widget to 48dp. * Remove the channel restriction on the widget. BUG=708844 Review-Url: https://codereview.chromium.org/2837503003 Cr-Commit-Position: refs/heads/master@{#466754} Committed: https://chromium.googlesource.com/chromium/src/+/17a2b98bcd2527244aadd8b73d6c6125ce083011

Patch Set 1 #

Patch Set 2 : 🔍 Make the widget taller and usable on all channels #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/java/res/layout/search_widget_template.xml View 3 chunks +7 lines, -13 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
gone
3 years, 8 months ago (2017-04-21 16:46:00 UTC) #2
Yusuf
lgtm
3 years, 8 months ago (2017-04-21 16:46:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837503003/20001
3 years, 8 months ago (2017-04-24 20:41:58 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 20:49:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/17a2b98bcd2527244aadd8b73d6c...

Powered by Google App Engine
This is Rietveld 408576698