Chromium Code Reviews
Help | Chromium Project | Sign in
(8)

Issue 2831233004: predictors: Add resource type to manifest.

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 days, 5 hours ago by alexilin
Modified:
3 days, 4 hours ago
Reviewers:
Benoit L
CC:
chromium-reviews, wifiprefetch-reviews_google.com
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Add resource type to manifest. This CL adds a new resource type field to the manifest proto. ResourcePrefetchPredictor begins to use this field to prefetch all resources of one resource type before another. BUG=699115

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -68 lines) Patch
M chrome/browser/predictors/resource_prefetch_predictor.cc View 3 chunks +21 lines, -5 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.proto View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_tables.h View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_tables.cc View 4 chunks +28 lines, -8 lines 1 comment Download
M chrome/browser/predictors/resource_prefetch_predictor_tables_unittest.cc View 3 chunks +39 lines, -7 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_test_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_test_util.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 9 chunks +56 lines, -32 lines 0 comments Download
M components/precache/core/proto/precache.proto View 1 chunk +14 lines, -0 lines 0 comments Download
Trybot results: Sign in to try more bots
Commit queue not available (can’t edit this change).

Messages

Total messages: 2 (1 generated)
alexilin
3 days, 4 hours ago (2017-04-21 12:07:28 UTC) #2
Hi Benoit! PTAL.

https://codereview.chromium.org/2831233004/diff/1/chrome/browser/predictors/r...
File chrome/browser/predictors/resource_prefetch_predictor_tables.cc (left):

https://codereview.chromium.org/2831233004/diff/1/chrome/browser/predictors/r...
chrome/browser/predictors/resource_prefetch_predictor_tables.cc:318: for (auto&
kv : *data_map) {
Resources are written to the database already sorted. There is no sense to
resort them when loading.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46