Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 2830313002: Split up TypeInferrer class. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by Paul Berry
Modified:
3 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split up TypeInferrer class. This CL makes four classes: - TypeInferrer, which is the API for type inference within a method body or field initializer, used by BodyBuilder. - TypeInferrerImpl, which is the generic implementation of TypeInferrer. - TypeInferenceEngine, which is the API for top level type inference and for creating TypeInferrers. - TypeInferenceEngineImpl, which is the generic implementation of TypeInferenceEngine. R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/925a0a577737fd9b672c961fd080f3a7fc609fc8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+364 lines, -235 lines) Patch
M pkg/front_end/lib/src/fasta/builder/builder.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart View 5 chunks +12 lines, -10 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 8 chunks +62 lines, -25 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_class_builder.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_loader.dart View 6 chunks +11 lines, -20 lines 0 comments Download
A pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart View 1 chunk +207 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 4 chunks +45 lines, -157 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 7 (3 generated)
Paul Berry
3 months ago (2017-04-21 11:59:50 UTC) #2
karlklose
LGTM, although I would prefer to use top-level and local in the names of the ...
3 months ago (2017-04-21 12:32:01 UTC) #4
Paul Berry
On 2017/04/21 12:32:01, karlklose wrote: > LGTM, although I would prefer to use top-level and ...
3 months ago (2017-04-21 12:37:36 UTC) #5
Paul Berry
3 months ago (2017-04-21 12:39:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
925a0a577737fd9b672c961fd080f3a7fc609fc8 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 25c286973