Chromium Code Reviews
Help | Chromium Project | Sign in
(3)

Issue 2819423002: Support flag --tabset-repeat on benchmark tab_switching

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 days, 14 hours ago by vovoy
Modified:
28 minutes ago
Reviewers:
perezju, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Support flag --tabset-repeat on benchmark tab_switching flag --tabset-repeat multiply the tab count of benchmark tab_switching to measure metrics on different tab count. ex: add flag --tabset-repeat=2 to double the tab count. BUG=689388

Patch Set 1 #

Total comments: 5

Patch Set 2 : fixing style #

Messages

Total messages: 27 (13 generated)
vovoy
it's the second part of Benchmark Tab Switching Refinement design doc: https://docs.google.com/document/d/1rMrrlW4-5ZGD9dHxUYBOzzkS-vyX0_mtiJ-CMT2egOY/edit#heading=h.7k3nrs3dk6g0
6 days, 11 hours ago (2017-04-18 05:46:28 UTC) #8
nednguyen
On 2017/04/18 05:46:28, vovoy wrote: > it's the second part of Benchmark Tab Switching Refinement ...
6 days, 5 hours ago (2017-04-18 11:17:30 UTC) #9
perezju
On 2017/04/18 11:17:30, nednguyen wrote: > On 2017/04/18 05:46:28, vovoy wrote: > > it's the ...
6 days, 4 hours ago (2017-04-18 12:58:09 UTC) #10
vovoy
On 2017/04/18 12:58:09, perezju wrote: > On 2017/04/18 11:17:30, nednguyen wrote: > > On 2017/04/18 ...
5 days, 7 hours ago (2017-04-19 09:49:41 UTC) #11
nednguyen
On 2017/04/19 09:49:41, vovoy wrote: > On 2017/04/18 12:58:09, perezju wrote: > > On 2017/04/18 ...
3 days, 5 hours ago (2017-04-21 11:37:10 UTC) #12
perezju
lgtm w/nits and a comment https://codereview.chromium.org/2819423002/diff/1/tools/perf/benchmarks/tab_switching.py File tools/perf/benchmarks/tab_switching.py (right): https://codereview.chromium.org/2819423002/diff/1/tools/perf/benchmarks/tab_switching.py#newcode42 tools/perf/benchmarks/tab_switching.py:42: return story_set Hmm, this ...
3 days, 5 hours ago (2017-04-21 11:59:48 UTC) #13
perezju
lgtm w/nits and a comment https://codereview.chromium.org/2819423002/diff/1/tools/perf/page_sets/system_health/multi_tab_stories.py File tools/perf/page_sets/system_health/multi_tab_stories.py (right): https://codereview.chromium.org/2819423002/diff/1/tools/perf/page_sets/system_health/multi_tab_stories.py#newcode16 tools/perf/page_sets/system_health/multi_tab_stories.py:16: ABSTRACT_STORY = True nit: ...
3 days, 5 hours ago (2017-04-21 11:59:48 UTC) #14
nednguyen
https://codereview.chromium.org/2819423002/diff/1/tools/perf/benchmarks/tab_switching.py File tools/perf/benchmarks/tab_switching.py (right): https://codereview.chromium.org/2819423002/diff/1/tools/perf/benchmarks/tab_switching.py#newcode42 tools/perf/benchmarks/tab_switching.py:42: return story_set On 2017/04/21 11:59:48, perezju wrote: > Hmm, ...
3 days, 4 hours ago (2017-04-21 12:14:03 UTC) #15
nednguyen
On 2017/04/21 12:14:03, nednguyen wrote: > https://codereview.chromium.org/2819423002/diff/1/tools/perf/benchmarks/tab_switching.py > File tools/perf/benchmarks/tab_switching.py (right): > > https://codereview.chromium.org/2819423002/diff/1/tools/perf/benchmarks/tab_switching.py#newcode42 > ...
3 days, 2 hours ago (2017-04-21 14:23:04 UTC) #16
vovoy
On 2017/04/21 14:23:04, nednguyen wrote: > On 2017/04/21 12:14:03, nednguyen wrote: > > > https://codereview.chromium.org/2819423002/diff/1/tools/perf/benchmarks/tab_switching.py ...
3 days, 1 hour ago (2017-04-21 16:04:51 UTC) #17
nednguyen
On 2017/04/21 16:04:51, vovoy wrote: > On 2017/04/21 14:23:04, nednguyen wrote: > > On 2017/04/21 ...
2 days, 11 hours ago (2017-04-22 05:53:13 UTC) #18
vovoy
On 2017/04/22 05:53:13, nednguyen wrote: > On 2017/04/21 16:04:51, vovoy wrote: > > On 2017/04/21 ...
1 day, 6 hours ago (2017-04-23 10:39:17 UTC) #19
nednguyen
lgtm After discussing on the other CL, we agree that using "is_multi_tab_test = True" is ...
4 hours, 59 minutes ago (2017-04-24 12:13:02 UTC) #20
vovoy
28 minutes ago (2017-04-24 16:43:49 UTC) #27
https://codereview.chromium.org/2819423002/diff/1/tools/perf/page_sets/system...
File tools/perf/page_sets/system_health/multi_tab_stories.py (right):

https://codereview.chromium.org/2819423002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/multi_tab_stories.py:16: ABSTRACT_STORY =
True
On 2017/04/21 11:59:48, perezju wrote:
> nit: add a blank like in between

Done.

https://codereview.chromium.org/2819423002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/multi_tab_stories.py:17: def __init__(self,
story_set, take_memory_measurement, tabset_repeat = 1):
On 2017/04/21 11:59:48, perezju wrote:
> nit: spacing, should be tabset_repeat=1

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46