Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Unified Diff: third_party/WebKit/Source/modules/permissions/Permissions.cpp

Issue 2791623004: [sensors][permission] Add new permission types in permission module. (Closed)
Patch Set: Use 1 single permissionName SENSORS, add ContentSettings Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/permissions/Permissions.cpp
diff --git a/third_party/WebKit/Source/modules/permissions/Permissions.cpp b/third_party/WebKit/Source/modules/permissions/Permissions.cpp
index 986ce16e2f7cd2dc9465316e675ae823d9ec4c13..1f196450f23f61a8251467004ea10538210f9900 100644
--- a/third_party/WebKit/Source/modules/permissions/Permissions.cpp
+++ b/third_party/WebKit/Source/modules/permissions/Permissions.cpp
@@ -21,6 +21,7 @@
#include "modules/permissions/PermissionDescriptor.h"
#include "modules/permissions/PermissionStatus.h"
#include "modules/permissions/PermissionUtils.h"
+#include "platform/RuntimeEnabledFeatures.h"
#include "platform/wtf/Functional.h"
#include "platform/wtf/NotFound.h"
#include "platform/wtf/PtrUtil.h"
@@ -91,6 +92,16 @@ PermissionDescriptorPtr ParsePermission(ScriptState* script_state,
}
if (name == "background-sync")
return CreatePermissionDescriptor(PermissionName::BACKGROUND_SYNC);
+ // TODO(riju): Remove runtime flag check when Generic Sensor feature is
+ // stable.
+ if (name == "ambient-light-sensor" || name == "accelerometer" ||
+ name == "gyroscope" || name == "magnetometer") {
+ if (!RuntimeEnabledFeatures::SensorEnabled()) {
+ exception_state.ThrowTypeError("GenericSensor flag is not enabled.");
+ return nullptr;
+ }
+ return CreatePermissionDescriptor(PermissionName::SENSORS);
+ }
return nullptr;
}

Powered by Google App Engine
This is Rietveld 408576698