Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Side by Side Diff: third_party/WebKit/Source/modules/permissions/Permissions.cpp

Issue 2791623004: [sensors][permission] Add new permission types in permission module. (Closed)
Patch Set: Use 1 single permissionName SENSORS, add ContentSettings Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/permissions/Permissions.h" 5 #include "modules/permissions/Permissions.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include "bindings/core/v8/Dictionary.h" 8 #include "bindings/core/v8/Dictionary.h"
9 #include "bindings/core/v8/Nullable.h" 9 #include "bindings/core/v8/Nullable.h"
10 #include "bindings/core/v8/ScriptPromise.h" 10 #include "bindings/core/v8/ScriptPromise.h"
11 #include "bindings/core/v8/ScriptPromiseResolver.h" 11 #include "bindings/core/v8/ScriptPromiseResolver.h"
12 #include "bindings/modules/v8/V8MidiPermissionDescriptor.h" 12 #include "bindings/modules/v8/V8MidiPermissionDescriptor.h"
13 #include "bindings/modules/v8/V8PermissionDescriptor.h" 13 #include "bindings/modules/v8/V8PermissionDescriptor.h"
14 #include "bindings/modules/v8/V8PushPermissionDescriptor.h" 14 #include "bindings/modules/v8/V8PushPermissionDescriptor.h"
15 #include "core/dom/DOMException.h" 15 #include "core/dom/DOMException.h"
16 #include "core/dom/Document.h" 16 #include "core/dom/Document.h"
17 #include "core/dom/ExceptionCode.h" 17 #include "core/dom/ExceptionCode.h"
18 #include "core/dom/ExecutionContext.h" 18 #include "core/dom/ExecutionContext.h"
19 #include "core/dom/UserGestureIndicator.h" 19 #include "core/dom/UserGestureIndicator.h"
20 #include "core/frame/LocalFrame.h" 20 #include "core/frame/LocalFrame.h"
21 #include "modules/permissions/PermissionDescriptor.h" 21 #include "modules/permissions/PermissionDescriptor.h"
22 #include "modules/permissions/PermissionStatus.h" 22 #include "modules/permissions/PermissionStatus.h"
23 #include "modules/permissions/PermissionUtils.h" 23 #include "modules/permissions/PermissionUtils.h"
24 #include "platform/RuntimeEnabledFeatures.h"
24 #include "platform/wtf/Functional.h" 25 #include "platform/wtf/Functional.h"
25 #include "platform/wtf/NotFound.h" 26 #include "platform/wtf/NotFound.h"
26 #include "platform/wtf/PtrUtil.h" 27 #include "platform/wtf/PtrUtil.h"
27 #include "platform/wtf/Vector.h" 28 #include "platform/wtf/Vector.h"
28 #include "public/platform/Platform.h" 29 #include "public/platform/Platform.h"
29 30
30 namespace blink { 31 namespace blink {
31 32
32 using mojom::blink::PermissionDescriptorPtr; 33 using mojom::blink::PermissionDescriptorPtr;
33 using mojom::blink::PermissionName; 34 using mojom::blink::PermissionName;
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 } 85 }
85 if (name == "midi") { 86 if (name == "midi") {
86 MidiPermissionDescriptor midi_permission = 87 MidiPermissionDescriptor midi_permission =
87 NativeValueTraits<MidiPermissionDescriptor>::NativeValue( 88 NativeValueTraits<MidiPermissionDescriptor>::NativeValue(
88 script_state->GetIsolate(), raw_permission.V8Value(), 89 script_state->GetIsolate(), raw_permission.V8Value(),
89 exception_state); 90 exception_state);
90 return CreateMidiPermissionDescriptor(midi_permission.sysex()); 91 return CreateMidiPermissionDescriptor(midi_permission.sysex());
91 } 92 }
92 if (name == "background-sync") 93 if (name == "background-sync")
93 return CreatePermissionDescriptor(PermissionName::BACKGROUND_SYNC); 94 return CreatePermissionDescriptor(PermissionName::BACKGROUND_SYNC);
95 // TODO(riju): Remove runtime flag check when Generic Sensor feature is
96 // stable.
97 if (name == "ambient-light-sensor" || name == "accelerometer" ||
98 name == "gyroscope" || name == "magnetometer") {
99 if (!RuntimeEnabledFeatures::SensorEnabled()) {
100 exception_state.ThrowTypeError("GenericSensor flag is not enabled.");
101 return nullptr;
102 }
103 return CreatePermissionDescriptor(PermissionName::SENSORS);
104 }
94 105
95 return nullptr; 106 return nullptr;
96 } 107 }
97 108
98 } // anonymous namespace 109 } // anonymous namespace
99 110
100 ScriptPromise Permissions::query(ScriptState* script_state, 111 ScriptPromise Permissions::query(ScriptState* script_state,
101 const Dictionary& raw_permission) { 112 const Dictionary& raw_permission) {
102 ExceptionState exception_state(script_state->GetIsolate(), 113 ExceptionState exception_state(script_state->GetIsolate(),
103 ExceptionState::kGetterContext, "Permissions", 114 ExceptionState::kGetterContext, "Permissions",
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 result.ReserveInitialCapacity(caller_index_to_internal_index.size()); 310 result.ReserveInitialCapacity(caller_index_to_internal_index.size());
300 for (int internal_index : caller_index_to_internal_index) { 311 for (int internal_index : caller_index_to_internal_index) {
301 result.push_back(PermissionStatus::CreateAndListen( 312 result.push_back(PermissionStatus::CreateAndListen(
302 resolver->GetExecutionContext(), results[internal_index], 313 resolver->GetExecutionContext(), results[internal_index],
303 descriptors[internal_index]->Clone())); 314 descriptors[internal_index]->Clone()));
304 } 315 }
305 resolver->Resolve(result); 316 resolver->Resolve(result);
306 } 317 }
307 318
308 } // namespace blink 319 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698