Chromium Code Reviews
Help | Chromium Project | Sign in
(1)

Issue 2788323002: SafeBrowsing: update interstitial layouts

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 2 days ago by Nate Fischer
Modified:
6 hours, 37 minutes ago
CC:
chromium-reviews, Jialiu Lin (OOO April 22-25)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

SafeBrowsing: change interstitial sizes This CL changes the CSS max-height, max-width, etc. dimensions for determining when to use mobile vs. desktop interstitial layouts. In particular, it targets: * wide and short views -> mobile landscape * skinny and tall views -> mobile portrait * wide and medium-height -> mobile landscape (w/ details on the same page) The phablet layout has been removed because it seems to actually be better to just use the mobile layout instead. This also allows the mobile layout to remain centered even for very wide views (parts of it were left-justified before), and reduces the top-margin for the icon in the mobile layout, since we were leaving a huge gap. BUG=707481

Patch Set 1 #

Patch Set 2 : Allow details to show below when view height is 600-736px #

Patch Set 3 : Don't let details button overlap back-to-safety #

Patch Set 4 : Increase top margin for middle-sized interstitials #

Patch Set 5 : Rebase off master #

Total comments: 10

Patch Set 6 : Switch to proportional margins #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -142 lines) Patch
M components/security_interstitials/core/browser/resources/interstitial_v2.css View 1 2 3 4 5 4 chunks +20 lines, -138 lines 2 comments Download
M components/security_interstitials/core/browser/resources/interstitial_v2_mobile.js View 1 2 3 4 5 1 chunk +3 lines, -4 lines 0 comments Download
Trybot results: Sign in to try more bots
Commit queue not available (can’t edit this change).

Messages

Total messages: 33 (19 generated)
Nate Fischer
nparker@: for owners approval edwardjung@: for UX design For your convenience, I've uploaded screenshots here: ...
2 weeks, 5 days ago (2017-04-04 23:32:56 UTC) #12
edwardjung
Nate, I'm currently OOO at a conference so won't be able to look at this ...
2 weeks, 5 days ago (2017-04-05 12:54:37 UTC) #13
Nate Fischer
On 2017/04/05 at 12:54:37, edwardjung wrote: > Nate, I'm currently OOO at a conference so ...
2 weeks, 4 days ago (2017-04-05 22:37:56 UTC) #14
edwardjung
> Thanks, Edward! Also, I just uploaded screenshots for Nexus 5X and 6P for both ...
2 weeks, 4 days ago (2017-04-06 13:01:50 UTC) #15
Nate Fischer
On 2017/04/06 at 13:01:50, edwardjung wrote: > > Thanks, Edward! Also, I just uploaded screenshots ...
2 weeks, 3 days ago (2017-04-07 04:44:31 UTC) #16
edwardjung
I had a chat with maxwalker@ (our designer who is working on webview safe browsing ...
1 week, 6 days ago (2017-04-11 14:58:55 UTC) #17
Nate Fischer
On 2017/04/11 at 14:58:55, edwardjung wrote: > I had a chat with maxwalker@ (our designer ...
1 week, 5 days ago (2017-04-11 17:12:12 UTC) #18
Nate Fischer
Edward, anything you want me to try out here? It wasn't clear to me if ...
1 week, 5 days ago (2017-04-12 16:10:11 UTC) #19
edwardjung
On 2017/04/12 16:10:11, Nate Fischer wrote: > Edward, anything you want me to try out ...
4 days, 7 hours ago (2017-04-20 09:55:09 UTC) #20
Nate Fischer
On 2017/04/20 at 09:55:09, edwardjung wrote: > On 2017/04/12 16:10:11, Nate Fischer wrote: > > ...
3 days, 22 hours ago (2017-04-20 19:03:41 UTC) #21
Nate Fischer
On 2017/04/20 at 19:03:41, Nate Fischer wrote: > On 2017/04/20 at 09:55:09, edwardjung wrote: > ...
3 days, 18 hours ago (2017-04-20 23:07:12 UTC) #26
edwardjung
Thanks Nate, I think this is mostly there. I would like to switch to proportional ...
3 days, 4 hours ago (2017-04-21 12:16:30 UTC) #31
Nate Fischer
I don't have an iOS device to try this out on, but this LGTM otherwise. ...
2 days, 22 hours ago (2017-04-21 18:28:43 UTC) #32
edwardjung
6 hours, 37 minutes ago (2017-04-24 10:30:41 UTC) #33
Just a couple of other changes.

Thanks.

https://codereview.chromium.org/2788323002/diff/80001/components/security_int...
File
components/security_interstitials/core/browser/resources/interstitial_v2_mobile.js
(right):

https://codereview.chromium.org/2788323002/diff/80001/components/security_int...
components/security_interstitials/core/browser/resources/interstitial_v2_mobile.js:16:
'(max-height: 640px) and (min-height: 240px) and ' +
No difference to the SSL, malware interstitials. This is specifically for some
network error pages.

https://codereview.chromium.org/2788323002/diff/100001/components/security_in...
File
components/security_interstitials/core/browser/resources/interstitial_v2.css
(right):

https://codereview.chromium.org/2788323002/diff/100001/components/security_in...
components/security_interstitials/core/browser/resources/interstitial_v2.css:438:
margin: 24px auto 12px;
Switch this to:
margin: 7vh auto 12px;

https://codereview.chromium.org/2788323002/diff/100001/components/security_in...
components/security_interstitials/core/browser/resources/interstitial_v2.css:484:
(orientation: portrait) {
Nit: align the opening brackets
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46