WebRTC Audio private API: removing WebRtcAudioPrivate(Set/Get)ActiveSinkFunction

WebRTC Audio private API: removing WebRtcAudioPrivate(Set/Get)ActiveSinkFunction
together with GetOutputControllers() logic from renderer hosts.

They are meant to be replaced with HTMLMediaElement's sinkId and setSinkId()

Landed after the users had switched to HTMLMediaElement.

BUG=647185, 672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2784563003
Cr-Commit-Position: refs/heads/master@{#466312}
Committed: https://chromium.googlesource.com/chromium/src/+/bc189a38337d30fd6a5450658ab3547126d97485

[o1ka, 2017-03-29 16:06:57]

Description was changed from

==========
WebRTC Audio private API: removing WebRtcAudioPrivate(Set/Get)ActiveSinkFunction
together with GetOutputControllers() logic from renderer hosts.

They are meant to be replaced with HTMLMediaElement's sinkId and setSinkId()

*PENDING on external change - do not submit yet*

BUG=647185,672468
==========

to

==========
WebRTC Audio private API: removing WebRtcAudioPrivate(Set/Get)ActiveSinkFunction
together with GetOutputControllers() logic from renderer hosts.

They are meant to be replaced with HTMLMediaElement's sinkId and setSinkId()

*PENDING on external change - do not submit yet*

BUG=647185,672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[o1ka, 2017-03-29 16:06:58]

Description was changed from

==========
WebRTC Audio private API: removing WebRtcAudioPrivate(Set/Get)ActiveSinkFunction
together with GetOutputControllers() logic from renderer hosts.

They are meant to be replaced with HTMLMediaElement's sinkId and setSinkId()

*PENDING on external change - do not submit yet*

BUG=647185,672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
WebRTC Audio private API: removing WebRtcAudioPrivate(Set/Get)ActiveSinkFunction
together with GetOutputControllers() logic from renderer hosts.

They are meant to be replaced with HTMLMediaElement's sinkId and setSinkId()

*PENDING on external change - do not submit yet*

BUG=647185,672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[o1ka, 2017-03-29 16:07:07]

The CQ bit was checked by olka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 16:07:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[o1ka, 2017-03-29 16:36:11]

Description was changed from

==========
WebRTC Audio private API: removing WebRtcAudioPrivate(Set/Get)ActiveSinkFunction
together with GetOutputControllers() logic from renderer hosts.

They are meant to be replaced with HTMLMediaElement's sinkId and setSinkId()

*PENDING on external change - do not submit yet*

BUG=647185,672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
WebRTC Audio private API: removing WebRtcAudioPrivate(Set/Get)ActiveSinkFunction
together with GetOutputControllers() logic from renderer hosts.

They are meant to be replaced with HTMLMediaElement's sinkId and setSinkId()

*PENDING on external change - do not submit yet*

BUG=647185,672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2017-03-29 17:58:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 17:58:17]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[o1ka, 2017-03-30 13:13:15]

The CQ bit was checked by olka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 13:13:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[o1ka, 2017-03-30 15:43:36]

olka@chromium.org changed reviewers:
+ sky@chromium.org, tommi@chromium.org

[o1ka, 2017-03-30 15:43:36]

I'm getting ready to land it as soon as the WebRTC audio private API client will
switch to using HTML (which is a CL under an active development now)

sky@chromium.org: Please review changes in chrome/

tommi@chromium.org: PTAL at the rest.

[commit-bot: I haz the power, 2017-03-30 15:48:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 15:48:37]

Dry run: This issue passed the CQ dry run.

[DaleCurtis, 2017-03-30 18:38:26]

\o/

[sky, 2017-03-30 20:50:35]

sky@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org
- sky@chromium.org

[sky, 2017-03-30 20:50:36]

I'm not at all familiar with this code.
sky->devlin

[Devlin, 2017-03-30 22:14:29]

Have the users of this API migrated away from these methods?

[o1ka, 2017-03-31 00:15:17]

On 2017/03/30 22:14:29, Devlin wrote:
> Have the users of this API migrated away from these methods?

See the comments above - the migration is in progress, I'll wait for their CLs
to land.

[Max Morin, 2017-03-31 07:04:19]

maxmorin@chromium.org changed reviewers:
+ maxmorin@chromium.org

[Max Morin, 2017-03-31 07:04:20]

I cannot resist: LGTM!!! :)
Some nits.

https://codereview.chromium.org/2784563003/diff/20001/chrome/browser/extensio...
File
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc
(right):

https://codereview.chromium.org/2784563003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc:270:
for (AudioDeviceDescriptions::const_iterator it = source_devices_.begin();
Could you rewrite this to a "for each" loop, since you are modifying this file
anyways? :) Actually, this seems to duplicate some code from one of the
managers, maybe there should just be a reverse hash lookup utility function
somewhere around there? No need to do it now though.

https://codereview.chromium.org/2784563003/diff/20001/chrome/browser/extensio...
File
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h
(right):

https://codereview.chromium.org/2784563003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h:73:
bool GetControllerList(const api::webrtc_audio_private::RequestInfo& request);
remove?

https://codereview.chromium.org/2784563003/diff/20001/chrome/browser/extensio...
File
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc
(right):

https://codereview.chromium.org/2784563003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc:61:
// or more AudioOutputController objects for our tab.
Could you reformulate this comment in terms of audibility rather than output
controllers?

https://codereview.chromium.org/2784563003/diff/20001/chrome/common/extension...
File chrome/common/extensions/api/webrtc_audio_private.idl (right):

https://codereview.chromium.org/2784563003/diff/20001/chrome/common/extension...
chrome/common/extensions/api/webrtc_audio_private.idl:6: // of audio output
(sink) devices
Add .

https://codereview.chromium.org/2784563003/diff/20001/chrome/test/data/extens...
File chrome/test/data/extensions/hangout_services_test.html (right):

https://codereview.chromium.org/2784563003/diff/20001/chrome/test/data/extens...
chrome/test/data/extensions/hangout_services_test.html:26: // Populates the
select box with information on all sinks
Add .

https://codereview.chromium.org/2784563003/diff/20001/content/browser/rendere...
File content/browser/renderer_host/media/audio_output_delegate_impl.h (left):

https://codereview.chromium.org/2784563003/diff/20001/content/browser/rendere...
content/browser/renderer_host/media/audio_output_delegate_impl.h:49: //
AudioOutputDelegate implementation.
Save comment?

[tommi (sloooow) - chröme, 2017-03-31 08:59:04]

I'm not resisting either - lgtm! :D

I'm unfortunately out of time for reviews today (I have several others too that
I need to attend to), so please regard my lgtm as more of a stamp of approval.
Thanks for driving this!

[o1ka, 2017-03-31 09:15:28]

Thanks Max!

https://codereview.chromium.org/2784563003/diff/20001/chrome/browser/extensio...
File
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc
(right):

https://codereview.chromium.org/2784563003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc:270:
for (AudioDeviceDescriptions::const_iterator it = source_devices_.begin();
On 2017/03/31 07:04:20, Max Morin wrote:
> Could you rewrite this to a "for each" loop, since you are modifying this file
> anyways? :) Actually, this seems to duplicate some code from one of the
> managers, maybe there should just be a reverse hash lookup utility function
> somewhere around there? No need to do it now though.

All this code will be changed to switch to AudioSysem - I'm intentionally not
touching it now.

https://codereview.chromium.org/2784563003/diff/20001/chrome/browser/extensio...
File
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h
(right):

https://codereview.chromium.org/2784563003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h:73:
bool GetControllerList(const api::webrtc_audio_private::RequestInfo& request);
On 2017/03/31 07:04:20, Max Morin wrote:
> remove?

Done.

https://codereview.chromium.org/2784563003/diff/20001/chrome/browser/extensio...
File
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc
(right):

https://codereview.chromium.org/2784563003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc:61:
// or more AudioOutputController objects for our tab.
On 2017/03/31 07:04:20, Max Morin wrote:
> Could you reformulate this comment in terms of audibility rather than output
> controllers?

Done.

https://codereview.chromium.org/2784563003/diff/20001/chrome/common/extension...
File chrome/common/extensions/api/webrtc_audio_private.idl (right):

https://codereview.chromium.org/2784563003/diff/20001/chrome/common/extension...
chrome/common/extensions/api/webrtc_audio_private.idl:6: // of audio output
(sink) devices
On 2017/03/31 07:04:20, Max Morin wrote:
> Add .

Done.

https://codereview.chromium.org/2784563003/diff/20001/chrome/test/data/extens...
File chrome/test/data/extensions/hangout_services_test.html (right):

https://codereview.chromium.org/2784563003/diff/20001/chrome/test/data/extens...
chrome/test/data/extensions/hangout_services_test.html:26: // Populates the
select box with information on all sinks
On 2017/03/31 07:04:20, Max Morin wrote:
> Add .

Done.

https://codereview.chromium.org/2784563003/diff/20001/content/browser/rendere...
File content/browser/renderer_host/media/audio_output_delegate_impl.h (left):

https://codereview.chromium.org/2784563003/diff/20001/content/browser/rendere...
content/browser/renderer_host/media/audio_output_delegate_impl.h:49: //
AudioOutputDelegate implementation.
On 2017/03/31 07:04:20, Max Morin wrote:
> Save comment?

Done.

[o1ka, 2017-03-31 09:16:24]

On 2017/03/31 08:59:04, tommi - chröme wrote:
> I'm not resisting either - lgtm! :D
> 
> I'm unfortunately out of time for reviews today (I have several others too
that
> I need to attend to), so please regard my lgtm as more of a stamp of approval.
> Thanks for driving this!

Thanks Tommi, I'll rely on Max's review.

[o1ka, 2017-04-05 10:18:20]

Devlin - ping?

[Devlin, 2017-04-05 14:13:55]

Sorry for the delay!  Thanks for the awesome cleanup :)

https://codereview.chromium.org/2784563003/diff/40001/chrome/common/extension...
File chrome/common/extensions/api/webrtc_audio_private.idl (right):

https://codereview.chromium.org/2784563003/diff/40001/chrome/common/extension...
chrome/common/extensions/api/webrtc_audio_private.idl:42: dictionary RequestInfo
{
This is no longer needed, right?

https://codereview.chromium.org/2784563003/diff/40001/content/browser/rendere...
File content/browser/renderer_host/media/audio_output_delegate_impl.cc (right):

https://codereview.chromium.org/2784563003/diff/40001/content/browser/rendere...
content/browser/renderer_host/media/audio_output_delegate_impl.cc:202: }
drive-by nit: \n

https://codereview.chromium.org/2784563003/diff/40001/extensions/browser/exte...
File extensions/browser/extension_function_histogram_value.h (right):

https://codereview.chromium.org/2784563003/diff/40001/extensions/browser/exte...
extensions/browser/extension_function_histogram_value.h:1231: // python
tools/metrics/histograms/update_extension_histograms.py
Please run this. :)

[o1ka, 2017-04-06 10:06:17]

The CQ bit was checked by olka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 10:06:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 11:53:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 11:53:14]

Dry run: This issue passed the CQ dry run.

[o1ka, 2017-04-06 12:18:30]

Thanks Devlin, comments addressed - PTAL.

https://codereview.chromium.org/2784563003/diff/40001/chrome/common/extension...
File chrome/common/extensions/api/webrtc_audio_private.idl (right):

https://codereview.chromium.org/2784563003/diff/40001/chrome/common/extension...
chrome/common/extensions/api/webrtc_audio_private.idl:42: dictionary RequestInfo
{
On 2017/04/05 14:13:55, Devlin wrote:
> This is no longer needed, right?

Done.

https://codereview.chromium.org/2784563003/diff/40001/content/browser/rendere...
File content/browser/renderer_host/media/audio_output_delegate_impl.cc (right):

https://codereview.chromium.org/2784563003/diff/40001/content/browser/rendere...
content/browser/renderer_host/media/audio_output_delegate_impl.cc:202: }
On 2017/04/05 14:13:55, Devlin wrote:
> drive-by nit: \n

Done.

https://codereview.chromium.org/2784563003/diff/40001/extensions/browser/exte...
File extensions/browser/extension_function_histogram_value.h (right):

https://codereview.chromium.org/2784563003/diff/40001/extensions/browser/exte...
extensions/browser/extension_function_histogram_value.h:1231: // python
tools/metrics/histograms/update_extension_histograms.py
On 2017/04/05 14:13:55, Devlin wrote:
> Please run this. :)

Oh thanks! No way I would have noticed this comment.
Done.

[o1ka, 2017-04-06 12:25:52]

olka@chromium.org changed reviewers:
+ avi@chromium.org, isherman@chromium.org

[o1ka, 2017-04-06 12:25:53]

isherman@chromium.org: Please review changes in 
extensions/browser/extension_function_histogram_value.h
tools/metrics/histograms/histograms.xml

avi@chromium.org: Please RS
content/browser/renderer_host/render_process_host_impl.h	content/browser/renderer_host/render_process_host_impl.cc	content/public/browser/render_process_host.h
(or *render_process_host* if you prefer)

Thanks!

[Avi (use Gerrit), 2017-04-06 15:13:27]

RenderProcessHost stuff lgtm

[Ilya Sherman, 2017-04-06 19:38:44]

histograms.xml lgtm

[Devlin, 2017-04-06 20:49:48]

extensions lgtm

[o1ka, 2017-04-07 09:01:16]

olka@chromium.org changed reviewers:
+ sky@chromium.org

[o1ka, 2017-04-07 09:01:16]

Thanks Devlin, Avi and Ilya.

sky@ Could you RS extensions?

[Devlin, 2017-04-07 14:35:47]

On 2017/04/07 09:01:16, o1ka wrote:
> Thanks Devlin, Avi and Ilya.
> 
> sky@ Could you RS extensions?

I'm an owner of extensions code, so my lg should be sufficient - are you seeing
a presubmit error?

[o1ka, 2017-04-07 14:42:17]

On 2017/04/07 14:35:47, Devlin wrote:
> On 2017/04/07 09:01:16, o1ka wrote:
> > Thanks Devlin, Avi and Ilya.
> > 
> > sky@ Could you RS extensions?
> 
> I'm an owner of extensions code, so my lg should be sufficient - are you
seeing
> a presubmit error?

Ah ok great - it's Chrome review plugin fooled me :)

[o1ka, 2017-04-07 14:42:47]

olka@chromium.org changed reviewers:
- sky@chromium.org

[o1ka, 2017-04-07 14:44:14]

On 2017/04/07 14:42:17, o1ka wrote:
> On 2017/04/07 14:35:47, Devlin wrote:
> > On 2017/04/07 09:01:16, o1ka wrote:
> > > Thanks Devlin, Avi and Ilya.
> > > 
> > > sky@ Could you RS extensions?
> > 
> > I'm an owner of extensions code, so my lg should be sufficient - are you
> seeing
> > a presubmit error?
> 
> Ah ok great - it's Chrome review plugin fooled me :)

removing sky@ from the reviewers since an owner LGTM already received.

Now waiting for the WebRtc private clients to land their changes.

[o1ka, 2017-04-07 14:44:59]

> Now waiting for the WebRtc private clients to land their changes.
* WebRtc audio private API clients

[o1ka, 2017-04-21 08:04:37]

The CQ bit was checked by olka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 08:04:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[o1ka, 2017-04-21 08:07:39]

olka@chromium.org changed reviewers:
+ grunell@chromium.org

[o1ka, 2017-04-21 08:07:40]

grunell@ could you RS chrome/browser/resources/hangout_services/thunk.js?
Thanks!

[Henrik Grunell, 2017-04-21 08:22:59]

Also update the version in
chrome/browser/resources/hangout_services/manifest.json (third number).

Then lgtm.

[o1ka, 2017-04-21 09:25:12]

The CQ bit was checked by olka@chromium.org

[o1ka, 2017-04-21 09:25:12]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org,
maxmorin@chromium.org, rdevlin.cronin@chromium.org, isherman@chromium.org,
avi@chromium.org, grunell@chromium.org
Link to the patchset: https://codereview.chromium.org/2784563003/#ps120001
(title: "updated api version")

[commit-bot: I haz the power, 2017-04-21 09:25:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[o1ka, 2017-04-21 09:25:36]

On 2017/04/21 08:22:59, Henrik Grunell wrote:
> Also update the version in
> chrome/browser/resources/hangout_services/manifest.json (third number).
> 
> Then lgtm.

thanks!

[commit-bot: I haz the power, 2017-04-21 11:19:47]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1492766712127800,
"parent_rev": "c75bf11da5566fccf6e1ca3de50ac489832d8634", "commit_rev":
"bc189a38337d30fd6a5450658ab3547126d97485"}

[commit-bot: I haz the power, 2017-04-21 11:19:59]

Description was changed from

==========
WebRTC Audio private API: removing WebRtcAudioPrivate(Set/Get)ActiveSinkFunction
together with GetOutputControllers() logic from renderer hosts.

They are meant to be replaced with HTMLMediaElement's sinkId and setSinkId()

*PENDING on external change - do not submit yet*

BUG=647185,672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
WebRTC Audio private API: removing WebRtcAudioPrivate(Set/Get)ActiveSinkFunction
together with GetOutputControllers() logic from renderer hosts.

They are meant to be replaced with HTMLMediaElement's sinkId and setSinkId()

*PENDING on external change - do not submit yet*

BUG=647185,672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2784563003
Cr-Commit-Position: refs/heads/master@{#466312}
Committed:
https://chromium.googlesource.com/chromium/src/+/bc189a38337d30fd6a5450658ab3...
==========

[commit-bot: I haz the power, 2017-04-21 11:20:01]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/bc189a38337d30fd6a5450658ab3...

[o1ka, 2017-04-21 11:34:21]

Description was changed from

==========
WebRTC Audio private API: removing WebRtcAudioPrivate(Set/Get)ActiveSinkFunction
together with GetOutputControllers() logic from renderer hosts.

They are meant to be replaced with HTMLMediaElement's sinkId and setSinkId()

*PENDING on external change - do not submit yet*

BUG=647185,672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2784563003
Cr-Commit-Position: refs/heads/master@{#466312}
Committed:
https://chromium.googlesource.com/chromium/src/+/bc189a38337d30fd6a5450658ab3...
==========

to

==========
WebRTC Audio private API: removing WebRtcAudioPrivate(Set/Get)ActiveSinkFunction
together with GetOutputControllers() logic from renderer hosts.

They are meant to be replaced with HTMLMediaElement's sinkId and setSinkId()

Landed after the users had switched to HTMLMediaElement.

BUG=647185,672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2784563003
Cr-Commit-Position: refs/heads/master@{#466312}
Committed:
https://chromium.googlesource.com/chromium/src/+/bc189a38337d30fd6a5450658ab3...
==========