Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Unified Diff: media/audio/audio_output_delegate.h

Issue 2784563003: WebRTC Audio private API: removing WebRtcAudioPrivate(Set/Get)ActiveSinkFunction (Closed)
Patch Set: updated api version Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/audio_output_controller_unittest.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_output_delegate.h
diff --git a/media/audio/audio_output_delegate.h b/media/audio/audio_output_delegate.h
index 3c121778c4f1019764c7fa7e21b52f3d475fb1d5..51bd491037eefdd1e25bf14a5cef9efcde7e9a84 100644
--- a/media/audio/audio_output_delegate.h
+++ b/media/audio/audio_output_delegate.h
@@ -19,8 +19,6 @@ class CancelableSyncSocket;
namespace media {
-class AudioOutputController;
-
class MEDIA_EXPORT AudioOutputDelegate {
public:
// An AudioOutputDelegate must not call back to its EventHandler in its
@@ -44,14 +42,6 @@ class MEDIA_EXPORT AudioOutputDelegate {
AudioOutputDelegate();
virtual ~AudioOutputDelegate();
- // TODO(maxmorin): Remove GetController() when crbug.com/647185 is closed.
- // This function is used to provide control of the audio stream to
- // WebrtcAudioPrivateGetActiveSinkFunction and others in the webrtc extension
- // API. Since the controller is shared, this means that it might outlive the
- // AudioOutputDelegate. In this case, it is still safe to call functions on
- // the controller, but it will not do anything. The controller is also shared
- // with AudioStreamMonitor.
- virtual scoped_refptr<AudioOutputController> GetController() const = 0;
virtual int GetStreamId() const = 0;
// Stream control:
« no previous file with comments | « media/audio/audio_output_controller_unittest.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698