Implemented parseSingleValue in CSSPropertyAPICounterIncrement.

Implemented parseSingleValue in CSSPropertyAPICounterIncrement.

Part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API.

This patch
- added parseSingleValue method to the CSSPropertyAPICounterIncrement
  API, with parsing logic from CSSPropertyParser
- removed CSSPropertyCounterIncrement from the switch statement in
  CSSPropertyParser::parseSingleValue, calling the API instead using
  a CSSPropertyDescriptor
- added parseSingleValue to counter-increment in CSSProperties.json5
  so it will be added to the generated files for the api

Diff in generated CSSPropertyAPICounterIncrement.h:
https://gist.github.com/BugsNash/ac16598cbe0677824308a64a52e33213/revisions
Diff in generated CSSPropertyDescriptor.cpp:
https://gist.github.com/BugsNash/7156559ba47f4ac929951959fe19cb93/revisions

BUG=668012
Review-Url: https://codereview.chromium.org/2783543002
Cr-Original-Commit-Position: refs/heads/master@{#462379}
Committed: https://chromium.googlesource.com/chromium/src/+/16f5c5b2155faa46890e2c5ad18bd27f7c506deb
Review-Url: https://codereview.chromium.org/2783543002
Cr-Commit-Position: refs/heads/master@{#462789}
Committed: https://chromium.googlesource.com/chromium/src/+/a61ff59e5d2030e2aaf4db89d8bb6767c410eb6d

[Bugs Nash, 2017-03-28 03:20:09]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 03:20:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 03:24:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 03:24:04]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Bugs Nash, 2017-03-28 03:31:55]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 03:32:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 03:35:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 03:35:28]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Bugs Nash, 2017-03-28 03:38:24]

bugsnash@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[Bugs Nash, 2017-03-28 04:08:22]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 04:08:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 05:46:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 05:46:54]

Dry run: This issue passed the CQ dry run.

[Eric Willigers, 2017-03-29 05:27:27]

lgtm

[Bugs Nash, 2017-03-29 06:04:31]

bugsnash@chromium.org changed reviewers:
+ meade@chromium.org

[Bugs Nash, 2017-03-29 06:06:24]

bugsnash@chromium.org changed reviewers:
+ meade@chromium.orgu
- meade@chromium.org

[Bugs Nash, 2017-03-29 06:06:25]

+meade@ for owners

[Bugs Nash, 2017-04-04 01:23:29]

bugsnash@chromium.org changed reviewers:
+ meade@chromium.org
- meade@chromium.orgu

[Bugs Nash, 2017-04-04 01:23:50]

whoops added wrong email for Eddy. bump :s

[meade_UTC10, 2017-04-06 03:01:16]

lgtm

[Bugs Nash, 2017-04-06 05:10:41]

The CQ bit was checked by bugsnash@chromium.org

[commit-bot: I haz the power, 2017-04-06 05:11:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 07:01:35]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491455441257980,
"parent_rev": "233f4e71bd49e79e477ef3ba814d53e8036e3c50", "commit_rev":
"16f5c5b2155faa46890e2c5ad18bd27f7c506deb"}

[commit-bot: I haz the power, 2017-04-06 07:07:56]

Description was changed from

==========
Implemented parseSingleValue in CSSPropertyAPICounterIncrement.

Part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API.

This patch
- added parseSingleValue method to the CSSPropertyAPICounterIncrement
  API, with parsing logic from CSSPropertyParser
- removed CSSPropertyCounterIncrement from the switch statement in
  CSSPropertyParser::parseSingleValue, calling the API instead using
  a CSSPropertyDescriptor
- added parseSingleValue to counter-increment in CSSProperties.json5
  so it will be added to the generated files for the api

Diff in generated CSSPropertyAPICounterIncrement.h:
https://gist.github.com/BugsNash/ac16598cbe0677824308a64a52e33213/revisions
Diff in generated CSSPropertyDescriptor.cpp:
https://gist.github.com/BugsNash/7156559ba47f4ac929951959fe19cb93/revisions

BUG=668012
==========

to

==========
Implemented parseSingleValue in CSSPropertyAPICounterIncrement.

Part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API.

This patch
- added parseSingleValue method to the CSSPropertyAPICounterIncrement
  API, with parsing logic from CSSPropertyParser
- removed CSSPropertyCounterIncrement from the switch statement in
  CSSPropertyParser::parseSingleValue, calling the API instead using
  a CSSPropertyDescriptor
- added parseSingleValue to counter-increment in CSSProperties.json5
  so it will be added to the generated files for the api

Diff in generated CSSPropertyAPICounterIncrement.h:
https://gist.github.com/BugsNash/ac16598cbe0677824308a64a52e33213/revisions
Diff in generated CSSPropertyDescriptor.cpp:
https://gist.github.com/BugsNash/7156559ba47f4ac929951959fe19cb93/revisions

BUG=668012

Review-Url: https://codereview.chromium.org/2783543002
Cr-Commit-Position: refs/heads/master@{#462379}
Committed:
https://chromium.googlesource.com/chromium/src/+/16f5c5b2155faa46890e2c5ad18b...
==========

[commit-bot: I haz the power, 2017-04-06 07:07:57]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/16f5c5b2155faa46890e2c5ad18b...

[awdf, 2017-04-06 07:32:07]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2801023002/ by awdf@chromium.org.

The reason for reverting is: Reverting due to compile failure on Android
builders:

../../third_party/WebKit/Source/core/css/properties/CSSPropertyAPICounterIncrement.cpp:11:17:
error: prototype for 'const blink::CSSValue*
blink::CSSPropertyAPICounterIncrement::parseSingleValue(blink::CSSParserTokenRange&,
const blink::CSSParserContext*)' does not match any in class
'blink::CSSPropertyAPICounterIncrement'
 const CSSValue* CSSPropertyAPICounterIncrement::parseSingleValue(
                 ^.

[awdf, 2017-04-06 07:57:26]

On 2017/04/06 07:32:07, awdf wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/2801023002/ by mailto:awdf@chromium.org.
> 
> The reason for reverting is: Reverting due to compile failure on Android
> builders:
> 
>
../../third_party/WebKit/Source/core/css/properties/CSSPropertyAPICounterIncrement.cpp:11:17:
> error: prototype for 'const blink::CSSValue*
>
blink::CSSPropertyAPICounterIncrement::parseSingleValue(blink::CSSParserTokenRange&,
> const blink::CSSParserContext*)' does not match any in class
> 'blink::CSSPropertyAPICounterIncrement'
>  const CSSValue* CSSPropertyAPICounterIncrement::parseSingleValue(
>                  ^.

Apologies, this may have been the wrong culprit. There was an autorevert of
another commit that
seems to have got things green again.

See https://bugs.chromium.org/p/chromium/issues/detail?id=708924

[Bugs Nash, 2017-04-07 00:30:31]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 00:31:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2017-04-07 00:53:04]

The CQ bit was unchecked by bugsnash@chromium.org

[Bugs Nash, 2017-04-07 00:53:06]

The CQ bit was checked by bugsnash@chromium.org

[Bugs Nash, 2017-04-07 00:53:07]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org,
ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/2783543002/#ps80001
(title: "Changed CSSParserContext pointer to reference for compatibility with
previous patch")

[commit-bot: I haz the power, 2017-04-07 00:53:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 06:05:44]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491526386940790,
"parent_rev": "7d902cae26ca61216e311a819855828a4c94bd1b", "commit_rev":
"a61ff59e5d2030e2aaf4db89d8bb6767c410eb6d"}

[commit-bot: I haz the power, 2017-04-07 06:07:18]

Description was changed from

==========
Implemented parseSingleValue in CSSPropertyAPICounterIncrement.

Part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API.

This patch
- added parseSingleValue method to the CSSPropertyAPICounterIncrement
  API, with parsing logic from CSSPropertyParser
- removed CSSPropertyCounterIncrement from the switch statement in
  CSSPropertyParser::parseSingleValue, calling the API instead using
  a CSSPropertyDescriptor
- added parseSingleValue to counter-increment in CSSProperties.json5
  so it will be added to the generated files for the api

Diff in generated CSSPropertyAPICounterIncrement.h:
https://gist.github.com/BugsNash/ac16598cbe0677824308a64a52e33213/revisions
Diff in generated CSSPropertyDescriptor.cpp:
https://gist.github.com/BugsNash/7156559ba47f4ac929951959fe19cb93/revisions

BUG=668012

Review-Url: https://codereview.chromium.org/2783543002
Cr-Commit-Position: refs/heads/master@{#462379}
Committed:
https://chromium.googlesource.com/chromium/src/+/16f5c5b2155faa46890e2c5ad18b...
==========

to

==========
Implemented parseSingleValue in CSSPropertyAPICounterIncrement.

Part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API.

This patch
- added parseSingleValue method to the CSSPropertyAPICounterIncrement
  API, with parsing logic from CSSPropertyParser
- removed CSSPropertyCounterIncrement from the switch statement in
  CSSPropertyParser::parseSingleValue, calling the API instead using
  a CSSPropertyDescriptor
- added parseSingleValue to counter-increment in CSSProperties.json5
  so it will be added to the generated files for the api

Diff in generated CSSPropertyAPICounterIncrement.h:
https://gist.github.com/BugsNash/ac16598cbe0677824308a64a52e33213/revisions
Diff in generated CSSPropertyDescriptor.cpp:
https://gist.github.com/BugsNash/7156559ba47f4ac929951959fe19cb93/revisions

BUG=668012

Review-Url: https://codereview.chromium.org/2783543002
Cr-Original-Commit-Position: refs/heads/master@{#462379}
Committed:
https://chromium.googlesource.com/chromium/src/+/16f5c5b2155faa46890e2c5ad18b...
Review-Url: https://codereview.chromium.org/2783543002
Cr-Commit-Position: refs/heads/master@{#462789}
Committed:
https://chromium.googlesource.com/chromium/src/+/a61ff59e5d2030e2aaf4db89d8bb...
==========

[commit-bot: I haz the power, 2017-04-07 06:07:19]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/a61ff59e5d2030e2aaf4db89d8bb...