Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Issue 2783533002: cros: do not set rotation for chrome.system.display API in touchview mode with user rotation locked (Closed)

Created:
3 years, 9 months ago by Qiang(Joe) Xu
Modified:
3 years, 8 months ago
Reviewers:
oshima
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: do not set rotation for chrome.system.display API in touchview mode with user rotation locked BUG=704931

Patch Set 1 #

Patch Set 2 : remove Shell::Get() cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -12 lines) Patch
M chrome/browser/extensions/display_info_provider_chromeos.cc View 1 3 chunks +20 lines, -3 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos_unittest.cc View 1 5 chunks +56 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
Qiang(Joe) Xu
3 years, 9 months ago (2017-03-28 03:11:25 UTC) #3
Hi oshima@, would you mind taking a look first? I am not sure if I am
understanding it all right, thanks!

Powered by Google App Engine
This is Rietveld 408576698