[package.proto] convert deps from list to map.

[package.proto] convert deps from list to map.

This is a backwards-incompatible proto change, but this CL makes the engine
compatible with BOTH versions (simultaneously :)).

Files handled by e.g. the autoroller code are 'sticky'. If they were
version 1, they'll be written as version 1. If they were version 2, they'll
be written as version 2.

Once version 2 is in use everywhere, I will remove support for version 1.

R=dnj@chromium.org, nodir@chromium.rog, phajdan.jr@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2779683005
Committed: https://github.com/luci/recipes-py/commit/4fcdb75517198a9ca32c7c4aecbe2e6f54b8b6c2

[iannucci, 2017-03-28 03:22:24]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 03:22:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iannucci, 2017-03-28 03:23:10]

Description was changed from

==========
[package.proto] convert deps from list to map.

This is a backwards-incompatible proto change, but this CL makes the engine
compatible with BOTH versions (simultaneously :)).

Files handled by e.g. the autoroller code are 'sticky'. If they were
version 1, they'll be written as version 1. If they were version 2, they'll
be written as version 2.

R=dnj@chromium.org, nodir@chromium.rog, phajdan.jr@chromium.org
BUG=
==========

to

==========
[package.proto] convert deps from list to map.

This is a backwards-incompatible proto change, but this CL makes the engine
compatible with BOTH versions (simultaneously :)).

Files handled by e.g. the autoroller code are 'sticky'. If they were
version 1, they'll be written as version 1. If they were version 2, they'll
be written as version 2.

Once version 1 is in use everywhere, I will remove support for version 2.

R=dnj@chromium.org, nodir@chromium.rog, phajdan.jr@chromium.org
BUG=
==========

[iannucci, 2017-03-28 03:23:23]

iannucci@chromium.org changed reviewers:
+ nodir@chromium.org
- nodir@chromium.rog

[iannucci, 2017-03-28 03:23:39]

PTAL (now with nodir's correct email address :))

[nodir, 2017-03-28 03:25:16]

> Once version 1 is in use everywhere, I will remove support for version 2.

you probably meant vice versa

[commit-bot: I haz the power, 2017-03-28 03:25:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 03:26:00]

Dry run: This issue passed the CQ dry run.

[iannucci, 2017-03-28 03:28:58]

Description was changed from

==========
[package.proto] convert deps from list to map.

This is a backwards-incompatible proto change, but this CL makes the engine
compatible with BOTH versions (simultaneously :)).

Files handled by e.g. the autoroller code are 'sticky'. If they were
version 1, they'll be written as version 1. If they were version 2, they'll
be written as version 2.

Once version 1 is in use everywhere, I will remove support for version 2.

R=dnj@chromium.org, nodir@chromium.rog, phajdan.jr@chromium.org
BUG=
==========

to

==========
[package.proto] convert deps from list to map.

This is a backwards-incompatible proto change, but this CL makes the engine
compatible with BOTH versions (simultaneously :)).

Files handled by e.g. the autoroller code are 'sticky'. If they were
version 1, they'll be written as version 1. If they were version 2, they'll
be written as version 2.

Once version 2 is in use everywhere, I will remove support for version 1.

R=dnj@chromium.org, nodir@chromium.rog, phajdan.jr@chromium.org
BUG=
==========

[iannucci, 2017-03-28 03:29:06]

On 2017/03/28 03:25:16, nodir wrote:
> > Once version 1 is in use everywhere, I will remove support for version 2.
> 
> you probably meant vice versa

hahaha yeah...

[nodir, 2017-03-28 03:36:13]

lgtm

https://codereview.chromium.org/2779683005/diff/1/recipe_engine/package.py
File recipe_engine/package.py (right):

https://codereview.chromium.org/2779683005/diff/1/recipe_engine/package.py#ne...
recipe_engine/package.py:85: 'expected %r to be in %r' % (vers,
self.API_VERSIONS)
to be one of

https://codereview.chromium.org/2779683005/diff/1/recipe_engine/package.py#ne...
recipe_engine/package.py:89: if 'deps' in obj and obj.get('api_version', 1) ==
1:
use vers

https://codereview.chromium.org/2779683005/diff/1/recipe_engine/package.py#ne...
recipe_engine/package.py:100: if 'deps' in obj and obj.get('api_version', 1) <
2:
use vers ?

[iannucci, 2017-03-28 04:06:10]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 04:06:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iannucci, 2017-03-28 04:06:18]

https://codereview.chromium.org/2779683005/diff/1/recipe_engine/package.py
File recipe_engine/package.py (right):

https://codereview.chromium.org/2779683005/diff/1/recipe_engine/package.py#ne...
recipe_engine/package.py:85: 'expected %r to be in %r' % (vers,
self.API_VERSIONS)
On 2017/03/28 03:36:13, nodir wrote:
> to be one of

Done.

https://codereview.chromium.org/2779683005/diff/1/recipe_engine/package.py#ne...
recipe_engine/package.py:89: if 'deps' in obj and obj.get('api_version', 1) ==
1:
On 2017/03/28 03:36:13, nodir wrote:
> use vers

Done.

https://codereview.chromium.org/2779683005/diff/1/recipe_engine/package.py#ne...
recipe_engine/package.py:100: if 'deps' in obj and obj.get('api_version', 1) <
2:
On 2017/03/28 03:36:13, nodir wrote:
> use vers ?

Done.

[commit-bot: I haz the power, 2017-03-28 04:10:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 04:10:46]

Dry run: Try jobs failed on following builders:
  Recipes-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/352beb45c9732e10)

[iannucci, 2017-03-28 04:14:40]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 04:14:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 04:18:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 04:18:18]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2017-03-28 15:40:33]

LGTM

[iannucci, 2017-03-28 16:10:53]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2017-03-28 16:10:54]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2779683005/#ps40001
(title: "fixit")

[commit-bot: I haz the power, 2017-03-28 16:11:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 16:14:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490717453915420,
"parent_rev": "8ec7b6d3ca59e7c178ad1b03e4408da556fddafa", "commit_rev":
"4fcdb75517198a9ca32c7c4aecbe2e6f54b8b6c2"}

[commit-bot: I haz the power, 2017-03-28 16:14:24]

Description was changed from

==========
[package.proto] convert deps from list to map.

This is a backwards-incompatible proto change, but this CL makes the engine
compatible with BOTH versions (simultaneously :)).

Files handled by e.g. the autoroller code are 'sticky'. If they were
version 1, they'll be written as version 1. If they were version 2, they'll
be written as version 2.

Once version 2 is in use everywhere, I will remove support for version 1.

R=dnj@chromium.org, nodir@chromium.rog, phajdan.jr@chromium.org
BUG=
==========

to

==========
[package.proto] convert deps from list to map.

This is a backwards-incompatible proto change, but this CL makes the engine
compatible with BOTH versions (simultaneously :)).

Files handled by e.g. the autoroller code are 'sticky'. If they were
version 1, they'll be written as version 1. If they were version 2, they'll
be written as version 2.

Once version 2 is in use everywhere, I will remove support for version 1.

R=dnj@chromium.org, nodir@chromium.rog, phajdan.jr@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2779683005
Committed:
https://github.com/luci/recipes-py/commit/4fcdb75517198a9ca32c7c4aecbe2e6f54b...
==========

[commit-bot: I haz the power, 2017-03-28 16:14:25]

Committed patchset #3 (id:40001) as
https://github.com/luci/recipes-py/commit/4fcdb75517198a9ca32c7c4aecbe2e6f54b...

[iannucci, 2017-03-28 16:16:42]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2785503002/ by iannucci@chromium.org.

The reason for reverting is: Prepping revert <just in case>.