Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2778953003: media: Add RunOnDestruction

Created:
3 years, 8 months ago by xhwang
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin (slow to review), Aaron Boodman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Add RunOnDestruction This is a decorator of base::OnceCallback which wraps the original callback into a new callback. When the callback runs, it runs the original callback. When the callback is destructed without ever running, the orignal callback will be run with parameters specified. BUG= TEST=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -2 lines) Patch
M media/base/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A media/base/run_on_destruction.h View 1 chunk +92 lines, -0 lines 0 comments Download
A media/base/run_on_destruction_unittest.cc View 1 chunk +203 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/binding_unittest.cc View 5 chunks +15 lines, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_service.mojom View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (5 generated)
xhwang
The CQ bit was checked by xhwang@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-03-28 07:27:18 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778953003/1
3 years, 8 months ago (2017-03-28 07:27:29 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-03-28 07:31:10 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/349409) linux_chromium_compile_dbg_ng on ...
3 years, 8 months ago (2017-03-28 07:31:11 UTC) #4
xhwang
3 years, 8 months ago (2017-03-28 22:50:46 UTC) #5
Description was changed from

==========
media: Add RunOnDestruction

This is a decorator of base::OnceCallback which wraps the original
callback into a new callback. When the callback runs, it runs the
original callback. When the callback is destructed, the orignal callback
will be run with parameters specified.

BUG=
TEST=
==========

to

==========
media: Add RunOnDestruction

This is a decorator of base::OnceCallback which wraps the original
callback into a new callback. When the callback runs, it runs the
original callback. When the callback is destructed without ever
running, the orignal callback will be run with parameters specified.

BUG=
TEST=
==========

Powered by Google App Engine
This is Rietveld 408576698