Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2778143002: More pre-MD cleanup (Closed)

Created:
3 years, 8 months ago by Evan Stade
Modified:
3 years, 8 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, tdanderson
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

More pre-MD cleanup Remove TrayDate (unused in MD) Remove non-MD code from TimeView Remove assets Remove non-MD code from SystemTray BUG=687804, 686234 Review-Url: https://codereview.chromium.org/2778143002 Cr-Commit-Position: refs/heads/master@{#460232} Committed: https://chromium.googlesource.com/chromium/src/+/c921567339528ecf4dd25e5c68ef756d3ce17052

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : additional #

Patch Set 4 : update c/b #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -597 lines) Patch
M ash/BUILD.gn View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
D ash/common/system/date/date_default_view.h View 1 chunk +0 lines, -53 lines 0 comments Download
D ash/common/system/date/date_default_view.cc View 1 chunk +0 lines, -146 lines 0 comments Download
M ash/common/system/date/date_view.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ash/common/system/date/date_view.cc View 1 9 chunks +35 lines, -102 lines 0 comments Download
D ash/common/system/date/tray_date.h View 1 chunk +0 lines, -76 lines 0 comments Download
D ash/common/system/date/tray_date.cc View 1 chunk +0 lines, -126 lines 0 comments Download
M ash/common/system/tray/default_system_tray_delegate.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/system/tray/default_system_tray_delegate.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M ash/common/system/tray/system_tray.h View 3 chunks +0 lines, -3 lines 0 comments Download
M ash/common/system/tray/system_tray.cc View 1 2 9 chunks +14 lines, -42 lines 0 comments Download
M ash/common/system/tray/system_tray_delegate.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M ash/common/system/tray/system_tray_delegate.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ash/resources/ash_resources.grd View 1 2 chunks +0 lines, -6 lines 0 comments Download
D ash/resources/default_100_percent/cros/status/status_help.png View 1 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_help_hover.png View 1 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_lockscreen.png View 1 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_lockscreen_hover.png View 1 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_shutdown.png View 1 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_shutdown_hover.png View 1 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_help.png View 1 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_help_hover.png View 1 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_lockscreen.png View 1 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_lockscreen_hover.png View 1 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_shutdown.png View 1 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_shutdown_hover.png View 1 Binary file 0 comments Download
M chrome/app/resources/locale_settings.grd View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/policy/device_system_use_24hour_clock_browsertest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/shutdown_policy_browsertest.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (17 generated)
Evan Stade
3 years, 8 months ago (2017-03-28 01:44:09 UTC) #5
oshima
On 2017/03/28 01:44:09, Evan Stade wrote: looks like there are several files are still using ...
3 years, 8 months ago (2017-03-28 13:06:55 UTC) #10
Evan Stade
indeed, I forgot to check the //chrome/ directory. All includes were stale --- updated.
3 years, 8 months ago (2017-03-28 15:58:00 UTC) #11
oshima
lgtm
3 years, 8 months ago (2017-03-28 20:47:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778143002/60001
3 years, 8 months ago (2017-03-28 20:53:29 UTC) #18
commit-bot: I haz the power
CQ has no permission to schedule in bucket master.tryserver.chromium.linux
3 years, 8 months ago (2017-03-28 21:15:51 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778143002/60001
3 years, 8 months ago (2017-03-28 22:46:41 UTC) #22
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 23:08:30 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c921567339528ecf4dd25e5c68ef...

Powered by Google App Engine
This is Rietveld 408576698