components/content_settings/core/browser/host_content_settings_map.cc - Issue 2776853002: Make UMA_HISTOGRAM_ENUMERATION work with scoped enums.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/host_content_settings_map.cc

Issue 2776853002: Make UMA_HISTOGRAM_ENUMERATION work with scoped enums. (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/metrics/histogram_macros_internal.h ('K') | « chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc ('k') | components/history/core/browser/history_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/host_content_settings_map.cc

diff --git a/components/content_settings/core/browser/host_content_settings_map.cc b/components/content_settings/core/browser/host_content_settings_map.cc

index d7e53a19ddd46cdcc87aaec38b4a2d372e04ca9a..3879f3096c0b32f26bb8077fd333adb59a9e1e78 100644

--- a/components/content_settings/core/browser/host_content_settings_map.cc

+++ b/components/content_settings/core/browser/host_content_settings_map.cc

@@ -611,11 +611,11 @@ void HostContentSettingsMap::RecordExceptionMetrics() {

int histogram_value =

ContentSettingTypeToHistogramValue(content_type, &num_values);

if (setting_entry.primary_pattern.HasPath()) {

- UMA_HISTOGRAM_ENUMERATION(

+ UMA_HISTOGRAM_EXACT_LINEAR(

"ContentSettings.ExceptionSchemeFile.Type.WithPath",

histogram_value, num_values);

} else {

- UMA_HISTOGRAM_ENUMERATION(

+ UMA_HISTOGRAM_EXACT_LINEAR(

"ContentSettings.ExceptionSchemeFile.Type.WithoutPath",

histogram_value, num_values);

}