Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9268)

Unified Diff: chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

Issue 2776853002: Make UMA_HISTOGRAM_ENUMERATION work with scoped enums. (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc
diff --git a/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc b/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc
index e9b8ae75343b3eb7bcd91c3c81aa1b4465a240b4..04f654f0b4bf6822631e639e5f3f8408dbc09b42 100644
--- a/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc
+++ b/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc
@@ -296,16 +296,16 @@ void ChangePictureHandler::HandleSelectImage(const base::ListValue* args) {
previous_image_,
user_manager::UserImage::FORMAT_JPEG));
- UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice",
- default_user_image::kHistogramImageOld,
- default_user_image::kHistogramImagesCount);
+ UMA_HISTOGRAM_EXACT_LINEAR("UserImage.ChangeChoice",
+ default_user_image::kHistogramImageOld,
+ default_user_image::kHistogramImagesCount);
VLOG(1) << "Selected old user image";
} else if (image_type == "default" &&
default_user_image::IsDefaultImageUrl(image_url, &image_index)) {
// One of the default user images.
user_image_manager->SaveUserDefaultImageIndex(image_index);
- UMA_HISTOGRAM_ENUMERATION(
+ UMA_HISTOGRAM_EXACT_LINEAR(
"UserImage.ChangeChoice",
default_user_image::GetDefaultImageHistogramValue(image_index),
default_user_image::kHistogramImagesCount);
@@ -323,14 +323,14 @@ void ChangePictureHandler::HandleSelectImage(const base::ListValue* args) {
user_image_manager->SaveUserImageFromProfileImage();
if (previous_image_index_ == user_manager::User::USER_IMAGE_PROFILE) {
- UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice",
- default_user_image::kHistogramImageOld,
- default_user_image::kHistogramImagesCount);
+ UMA_HISTOGRAM_EXACT_LINEAR("UserImage.ChangeChoice",
+ default_user_image::kHistogramImageOld,
+ default_user_image::kHistogramImagesCount);
VLOG(1) << "Selected old (profile) user image";
} else {
- UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice",
- default_user_image::kHistogramImageFromProfile,
- default_user_image::kHistogramImagesCount);
+ UMA_HISTOGRAM_EXACT_LINEAR("UserImage.ChangeChoice",
+ default_user_image::kHistogramImageFromProfile,
+ default_user_image::kHistogramImagesCount);
VLOG(1) << "Selected profile image";
}
} else {
@@ -348,9 +348,9 @@ void ChangePictureHandler::FileSelected(const base::FilePath& path,
ChromeUserManager::Get()
->GetUserImageManager(GetUser()->GetAccountId())
->SaveUserImageFromFile(path);
- UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice",
- default_user_image::kHistogramImageFromFile,
- default_user_image::kHistogramImagesCount);
+ UMA_HISTOGRAM_EXACT_LINEAR("UserImage.ChangeChoice",
+ default_user_image::kHistogramImageFromFile,
+ default_user_image::kHistogramImagesCount);
VLOG(1) << "Selected image from file";
}
@@ -359,9 +359,9 @@ void ChangePictureHandler::SetImageFromCamera(const gfx::ImageSkia& photo) {
->GetUserImageManager(GetUser()->GetAccountId())
->SaveUserImage(user_manager::UserImage::CreateAndEncode(
photo, user_manager::UserImage::FORMAT_JPEG));
- UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice",
- default_user_image::kHistogramImageFromCamera,
- default_user_image::kHistogramImagesCount);
+ UMA_HISTOGRAM_EXACT_LINEAR("UserImage.ChangeChoice",
+ default_user_image::kHistogramImageFromCamera,
+ default_user_image::kHistogramImagesCount);
VLOG(1) << "Selected camera photo";
}

Powered by Google App Engine
This is Rietveld 408576698