Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2775993002: Crash Fix (Cast Streaming): Render overlay on copy of source frame. (Closed)

Created:
3 years, 9 months ago by miu
Modified:
3 years, 9 months ago
Reviewers:
xjz
CC:
chromium-reviews, imcheng+watch_chromium.org, posciak+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Crash Fix (Cast Streaming): Render overlay on copy of source frame. Due to major overhaul going on in the Video Capture stack, the video frames sent to the render process have become read-only (they used to be read-write). The "performance overlay" debugging utility would just modify pixels on source video frames, and in the new world this caused a page fault. Solution: Now, it must first make a copy of the frame. BUG=677341 Review-Url: https://codereview.chromium.org/2775993002 Cr-Commit-Position: refs/heads/master@{#459882} Committed: https://chromium.googlesource.com/chromium/src/+/dcb83c6cb421c934ca933260391390ad5038bb70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -70 lines) Patch
M media/cast/sender/performance_metrics_overlay.h View 2 chunks +23 lines, -17 lines 0 comments Download
M media/cast/sender/performance_metrics_overlay.cc View 6 chunks +69 lines, -41 lines 0 comments Download
M media/cast/sender/video_sender.cc View 1 chunk +10 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
miu
xjz: PTAL.
3 years, 9 months ago (2017-03-25 02:50:52 UTC) #2
xjz
lgtm
3 years, 9 months ago (2017-03-27 17:27:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775993002/1
3 years, 9 months ago (2017-03-27 19:16:30 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 21:22:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dcb83c6cb421c934ca9332603913...

Powered by Google App Engine
This is Rietveld 408576698