Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2775003003: Move Node::lengthOfContents into Range, its only user. (Closed)

Created:
3 years, 9 months ago by esprehn
Modified:
3 years, 9 months ago
Reviewers:
haraken, ojan
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Node::lengthOfContents into Range, its only user. Node has so many methods, lets move this Range specific one to inside Range.cpp. I also removed the Attr test which didn't really make sense. Review-Url: https://codereview.chromium.org/2775003003 Cr-Commit-Position: refs/heads/master@{#459661} Committed: https://chromium.googlesource.com/chromium/src/+/cb3466e6dad6e3cb829df8ebe4dc56d806168c84

Patch Set 1 #

Patch Set 2 : const. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -32 lines) Patch
M third_party/WebKit/Source/core/dom/AttrTest.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Range.cpp View 1 4 chunks +25 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
esprehn
3 years, 9 months ago (2017-03-25 01:14:49 UTC) #2
haraken
LGTM
3 years, 9 months ago (2017-03-25 04:42:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775003003/20001
3 years, 9 months ago (2017-03-25 22:56:20 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-25 23:00:35 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cb3466e6dad6e3cb829df8ebe4dc...

Powered by Google App Engine
This is Rietveld 408576698