Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2774753005:
printing: add missing header files to BUILD.gn (Closed)
Descriptionprinting: add missing header files to BUILD.gn
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0ywe7bZs/edit#gid=0
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/1kK45mVemBc/discussion
BUG=661774
R=thestig@chromium.org
Review-Url: https://codereview.chromium.org/2774753005
Cr-Commit-Position: refs/heads/master@{#459626}
Committed: https://chromium.googlesource.com/chromium/src/+/4772a46e8ad389ccddacf46ab84cd0212e60b86d
Patch Set 1 #Patch Set 2 : ipc dep #Patch Set 3 : another dep #Patch Set 4 : ipc/skia #
Total comments: 2
Patch Set 5 : remove ipc includes #Messages
Total messages: 27 (21 generated)
The CQ bit was checked by tfarina@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
The CQ bit was checked by tfarina@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by tfarina@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by tfarina@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2774753005/diff/60001/printing/BUILD.gn File printing/BUILD.gn (right): https://codereview.chromium.org/2774753005/diff/60001/printing/BUILD.gn#newco... printing/BUILD.gn:97: "//ipc", Can you just remove all the ipc includes in pdf_render_settings.h? I don't think they are actually needed.
https://codereview.chromium.org/2774753005/diff/60001/printing/BUILD.gn File printing/BUILD.gn (right): https://codereview.chromium.org/2774753005/diff/60001/printing/BUILD.gn#newco... printing/BUILD.gn:97: "//ipc", On 2017/03/25 01:12:50, Lei Zhang wrote: > Can you just remove all the ipc includes in pdf_render_settings.h? I don't think > they are actually needed. Done.
The CQ bit was checked by tfarina@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tfarina@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490408547718430,
"parent_rev": "f478d76ee3acd92b6a2cf5ff2e5a0e4094c756db", "commit_rev":
"4772a46e8ad389ccddacf46ab84cd0212e60b86d"}
Message was sent while issue was closed.
Description was changed from ========== printing: add missing header files to BUILD.gn https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y... https://groups.google.com/a/chromium.org/d/topic/chromium-dev/1kK45mVemBc/dis... BUG=661774 R=thestig@chromium.org ========== to ========== printing: add missing header files to BUILD.gn https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y... https://groups.google.com/a/chromium.org/d/topic/chromium-dev/1kK45mVemBc/dis... BUG=661774 R=thestig@chromium.org Review-Url: https://codereview.chromium.org/2774753005 Cr-Commit-Position: refs/heads/master@{#459626} Committed: https://chromium.googlesource.com/chromium/src/+/4772a46e8ad389ccddacf46ab84c... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/4772a46e8ad389ccddacf46ab84c... |
