Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2774463002: image_decoder service -> data_decoder service (Closed)

Created:
3 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 9 months ago
Reviewers:
jam
CC:
Aaron Boodman, abarth-chromium, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, extensions-reviews_chromium.org, jam, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, tfarina, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

image_decoder service -> data_decoder service Establishes a more generic service definition for a thing to do sandboxed data decoding. This is just a rename of the existing image_decoder service. Since there is nothing Chrome specific about this service, and there is now some motivation to use sandboxed image decoding outside of Chrome, this also moves the packaging of the service from chrome into content. BUG=697557 TBR=tsepez@chromium.org Review-Url: https://codereview.chromium.org/2774463002 Cr-Commit-Position: refs/heads/master@{#459631} Committed: https://chromium.googlesource.com/chromium/src/+/e04370309e452bfdbad223228b908c7e31f2809c

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -807 lines) Patch
M chrome/app/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/DEPS View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chrome_content_browser_manifest_overlay.json View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/image_decoder.cc View 6 chunks +13 lines, -13 lines 0 comments Download
M chrome/utility/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/utility/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/utility/chrome_content_utility_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 4 chunks +0 lines, -15 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_manager/service_manager_context.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/public/app/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/utility/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/utility/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/utility/utility_service_factory.cc View 3 chunks +16 lines, -0 lines 0 comments Download
M services/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
A + services/data_decoder/BUILD.gn View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
A + services/data_decoder/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A services/data_decoder/README.md View 1 chunk +3 lines, -0 lines 0 comments Download
A + services/data_decoder/data_decoder_service.h View 3 chunks +10 lines, -10 lines 0 comments Download
A + services/data_decoder/data_decoder_service.cc View 3 chunks +16 lines, -17 lines 0 comments Download
A + services/data_decoder/image_decoder_impl.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + services/data_decoder/image_decoder_impl.cc View 1 2 3 4 chunks +14 lines, -8 lines 0 comments Download
A + services/data_decoder/image_decoder_impl_unittest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
A + services/data_decoder/manifest.json View 1 chunk +3 lines, -3 lines 0 comments Download
A + services/data_decoder/public/cpp/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
A + services/data_decoder/public/cpp/decode_image.h View 3 chunks +14 lines, -14 lines 0 comments Download
A + services/data_decoder/public/cpp/decode_image.cc View 3 chunks +11 lines, -11 lines 0 comments Download
A + services/data_decoder/public/interfaces/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/data_decoder/public/interfaces/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/data_decoder/public/interfaces/constants.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/data_decoder/public/interfaces/image_decoder.mojom View 1 chunk +1 line, -1 line 0 comments Download
D services/image_decoder/BUILD.gn View 1 chunk +0 lines, -55 lines 0 comments Download
D services/image_decoder/DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
D services/image_decoder/README.md View 1 chunk +0 lines, -3 lines 0 comments Download
D services/image_decoder/image_decoder_impl.h View 1 chunk +0 lines, -39 lines 0 comments Download
D services/image_decoder/image_decoder_impl.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D services/image_decoder/image_decoder_impl_unittest.cc View 1 chunk +0 lines, -164 lines 0 comments Download
D services/image_decoder/image_decoder_service.h View 1 chunk +0 lines, -43 lines 0 comments Download
D services/image_decoder/image_decoder_service.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D services/image_decoder/manifest.json View 1 chunk +0 lines, -14 lines 0 comments Download
D services/image_decoder/public/cpp/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D services/image_decoder/public/cpp/decode.h View 1 chunk +0 lines, -45 lines 0 comments Download
D services/image_decoder/public/cpp/decode.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D services/image_decoder/public/interfaces/BUILD.gn View 1 chunk +0 lines, -23 lines 0 comments Download
D services/image_decoder/public/interfaces/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D services/image_decoder/public/interfaces/constants.mojom View 1 chunk +0 lines, -7 lines 0 comments Download
D services/image_decoder/public/interfaces/image_decoder.mojom View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 31 (22 generated)
Ken Rockot(use gerrit already)
PTAL. Sorry for the size - most of the work is just a mechanical move. ...
3 years, 9 months ago (2017-03-22 22:35:07 UTC) #4
jam
lgtm
3 years, 9 months ago (2017-03-24 23:53:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774463002/60001
3 years, 9 months ago (2017-03-24 23:58:21 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/394593)
3 years, 9 months ago (2017-03-25 00:09:01 UTC) #20
Ken Rockot(use gerrit already)
+TBR tsepez@, just shuffling some things around.
3 years, 9 months ago (2017-03-25 00:13:29 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774463002/60001
3 years, 9 months ago (2017-03-25 00:13:57 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/391247)
3 years, 9 months ago (2017-03-25 00:35:54 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774463002/60001
3 years, 9 months ago (2017-03-25 01:32:22 UTC) #28
commit-bot: I haz the power
3 years, 9 months ago (2017-03-25 02:50:46 UTC) #31
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e04370309e452bfdbad223228b90...

Powered by Google App Engine
This is Rietveld 408576698