Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc

Issue 2773183003: Fix DCHECK crash failed: object->isLayoutNGBlockFlow() in Inline Builder (Closed)
Patch Set: update TestExpectations Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc b/third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc
index 8812b428f8d94248ad92f4a013ac3b821b604f6c..dc91de25eeec2db6f4066f9beebf6bcccb38af3b 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc
@@ -309,11 +309,10 @@ void NGLineBuilder::BidiReorder(Vector<LineItemChunk, 32>* line_item_chunks) {
// TODO(glebl): Add the support of clearance for inline floats.
void NGLineBuilder::LayoutAndPositionFloat(LayoutUnit end_position,
LayoutObject* layout_object) {
- LayoutNGBlockFlow* block_flow = toLayoutNGBlockFlow(layout_object);
- NGBlockNode* node = new NGBlockNode(block_flow);
-
+ NGBlockNode* node = new NGBlockNode(layout_object);
RefPtr<NGConstraintSpace> float_space = CreateConstraintSpaceForFloat(
node->Style(), ConstraintSpace(), &space_builder_);
+
// TODO(glebl): add the fragmentation support:
// same writing mode - get the inline size ComputeInlineSizeForFragment to
// determine if it fits on this line, then perform layout with the correct
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698