Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2773183003: Fix DCHECK crash failed: object->isLayoutNGBlockFlow() in Inline Builder (Closed)

Created:
3 years, 9 months ago by Gleb Lanbin
Modified:
3 years, 9 months ago
Reviewers:
ikilpatrick
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DCHECK crash failed: object->isLayoutNGBlockFlow() in Inline Builder We cannot cast every inline floating object to LayoutNGBlockFlow because not all of them support LayoutNG. We need to use NGBlockNode->Layout which supports legacy layout as well. BUG=635619 Review-Url: https://codereview.chromium.org/2773183003 Cr-Commit-Position: refs/heads/master@{#459620} Committed: https://chromium.googlesource.com/chromium/src/+/827e3e9ad3709d6ff335ec9bafd1e536ea78b09f

Patch Set 1 #

Patch Set 2 : update TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -52 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 10 chunks +35 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Gleb Lanbin
I need to update TestExpectations as well.
3 years, 9 months ago (2017-03-24 23:03:54 UTC) #2
ikilpatrick
lgtm
3 years, 9 months ago (2017-03-24 23:06:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773183003/20001
3 years, 9 months ago (2017-03-25 01:52:04 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-25 01:57:28 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/827e3e9ad3709d6ff335ec9bafd1...

Powered by Google App Engine
This is Rietveld 408576698