Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2771723006: [recipes.cfg] ONLY support jsonpb. (Closed)

Created:
3 years, 9 months ago by iannucci
Modified:
3 years, 9 months ago
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[recipes.cfg] ONLY support jsonpb. We can now remove all support for the text proto version of recipes.cfg. R=dnj@chromium.org, nodir@chromium.org, phajdan.jr@chromium.org BUG=699379 Review-Url: https://codereview.chromium.org/2771723006 Committed: https://github.com/luci/recipes-py/commit/51395b1ba1ea684f5e99d2bb03c934f2ac441984

Patch Set 1 #

Patch Set 2 : fix fetch and test #

Total comments: 1

Patch Set 3 : remove comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -154 lines) Patch
M doc/recipes.py View 2 chunks +11 lines, -89 lines 0 comments Download
M recipe_engine/fetch.py View 1 2 chunks +3 lines, -2 lines 0 comments Download
M recipe_engine/package.py View 1 2 3 chunks +3 lines, -17 lines 0 comments Download
M recipe_engine/unittests/fetch_test.py View 1 1 chunk +5 lines, -5 lines 0 comments Download
M unittests/errors_test.py View 1 chunk +13 lines, -11 lines 0 comments Download
M unittests/package_test.py View 4 chunks +24 lines, -30 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
iannucci
3 years, 9 months ago (2017-03-25 01:44:05 UTC) #1
dnj
woohoo, lgtm https://codereview.chromium.org/2771723006/diff/20001/doc/recipes.py File doc/recipes.py (left): https://codereview.chromium.org/2771723006/diff/20001/doc/recipes.py#oldcode110 doc/recipes.py:110: def parse_textpb(fh): Uh .. wow, I forgot ...
3 years, 9 months ago (2017-03-25 01:54:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771723006/40001
3 years, 9 months ago (2017-03-25 02:21:12 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-25 02:24:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/recipes-py/commit/51395b1ba1ea684f5e99d2bb03c934f2ac4...

Powered by Google App Engine
This is Rietveld 408576698