Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2771533004:
[DevTools] Make timeline popover easier to use on small screens (Closed)
|
Created:
3 years, 9 months ago by dgozman Modified:
3 years, 9 months ago Reviewers:
caseq CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] Keep a margin between cursor and timeline popover
This improves timeline popover UX on small screens significantly.
Review-Url: https://codereview.chromium.org/2771533004
Cr-Commit-Position: refs/heads/master@{#459628}
Committed: https://chromium.googlesource.com/chromium/src/+/3115102fe183766082bc4d12b78fd672c7481345
Patch Set 1 #
Total comments: 3
Patch Set 2 : addressed comments #
Total comments: 2
Patch Set 3 : fix #Messages
Total messages: 18 (9 generated)
dgozman@chromium.org changed reviewers: + caseq@chromium.org
Could you please take a look?
I'm fine with #1 modulo comments, but I don't think #2 is a right way to fix the problem. So let's drop #2 along with a bug reference, land #1 and come up with a more radical way to fix #2. https://codereview.chromium.org/2771533004/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js (right): https://codereview.chromium.org/2771533004/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js:243: else if (!enoughHeight) This is somehow unfortunate considering we already check this in if. Let's rephrase this as if (!enoughHeight) ... else if (<old-condition>) ... https://codereview.chromium.org/2771533004/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js:301: else if (!enoughWidth) ditto.
Please take another look. https://codereview.chromium.org/2771533004/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js (right): https://codereview.chromium.org/2771533004/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js:243: else if (!enoughHeight) On 2017/03/22 23:30:03, caseq wrote: > This is somehow unfortunate considering we already check this in if. > Let's rephrase this as > > if (!enoughHeight) > ... > else if (<old-condition>) > ... Done.
lgtm, but please adjust CL description and remove bug reference https://codereview.chromium.org/2771533004/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js (right): https://codereview.chromium.org/2771533004/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js:301: else if (enoughWidth && this._showArrow && positionY - arrowSize >= gutterSize) drop enoughWidth from here, that was the whole point :-)
Description was changed from ========== [DevTools] Make timeline popover easier to use on small screens. Two improvements: - keep a margin between cursor and contents when popover does not fit; - make popover disappear on click. BUG=700273 ========== to ========== [DevTools] Keep a margin between cursor and timeline popover This improves timeline popover UX on small screens significantly. BUG=700273 ==========
Description was changed from ========== [DevTools] Keep a margin between cursor and timeline popover This improves timeline popover UX on small screens significantly. BUG=700273 ========== to ========== [DevTools] Keep a margin between cursor and timeline popover This improves timeline popover UX on small screens significantly. ==========
https://codereview.chromium.org/2771533004/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js (right): https://codereview.chromium.org/2771533004/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js:301: else if (enoughWidth && this._showArrow && positionY - arrowSize >= gutterSize) On 2017/03/23 00:46:14, caseq wrote: > drop enoughWidth from here, that was the whole point :-) Thanks, I am being sloppy in this patch...
The CQ bit was checked by dgozman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org Link to the patchset: https://codereview.chromium.org/2771533004/#ps40001 (title: "fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490403984230250,
"parent_rev": "466023119ab84e9d0b54af4fad4a32c72f7092a0", "commit_rev":
"3115102fe183766082bc4d12b78fd672c7481345"}
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Keep a margin between cursor and timeline popover This improves timeline popover UX on small screens significantly. ========== to ========== [DevTools] Keep a margin between cursor and timeline popover This improves timeline popover UX on small screens significantly. Review-Url: https://codereview.chromium.org/2771533004 Cr-Commit-Position: refs/heads/master@{#459628} Committed: https://chromium.googlesource.com/chromium/src/+/3115102fe183766082bc4d12b78f... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/3115102fe183766082bc4d12b78f... |
