Feed ScrollableArea::showOverlayScrollbars into ScrollbarAnimationController.

Feed ScrollableArea::showOverlayScrollbars into ScrollbarAnimationController.

No behavior change yet since every scroll currently hits SAC::DidScrollUpdate,
but this adds plumbing to let Blink make the decision.

BUG=606395
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2770293003
Cr-Commit-Position: refs/heads/master@{#460178}
Committed: https://chromium.googlesource.com/chromium/src/+/56451775d90238d9def5e9663771de8d0ca7ef6f

[skobes, 2017-03-25 01:05:45]

Description was changed from

==========
Feed ScrollableArea::showOverlayScrollbars into ScrollbarAnimationController.

No behavior change yet since we already call SAC::DidScrollUpdate for every
scroll, but this adds the plumbing to let Blink make the decision.

BUG=606395
==========

to

==========
Feed ScrollableArea::showOverlayScrollbars into ScrollbarAnimationController.

No behavior change yet since we already call SAC::DidScrollUpdate for every
scroll, but this adds the plumbing to let Blink make the decision.

BUG=606395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[skobes, 2017-03-25 01:05:46]

Description was changed from

==========
Feed ScrollableArea::showOverlayScrollbars into ScrollbarAnimationController.

No behavior change yet since we already call SAC::DidScrollUpdate for every
scroll, but this adds the plumbing to let Blink make the decision.

BUG=606395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Feed ScrollableArea::showOverlayScrollbars into ScrollbarAnimationController.

No behavior change yet since we already call SAC::DidScrollUpdate for every
scroll, but this adds the plumbing to let Blink make the decision.

BUG=606395
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[skobes, 2017-03-25 01:06:36]

The CQ bit was checked by skobes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-25 01:07:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skobes, 2017-03-25 01:18:57]

Description was changed from

==========
Feed ScrollableArea::showOverlayScrollbars into ScrollbarAnimationController.

No behavior change yet since we already call SAC::DidScrollUpdate for every
scroll, but this adds the plumbing to let Blink make the decision.

BUG=606395
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Feed ScrollableArea::showOverlayScrollbars into ScrollbarAnimationController.

No behavior change yet since every scroll currently hits SAC::DidScrollUpdate,
but this adds plumbing to let Blink make the decision.

BUG=606395
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2017-03-25 02:46:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 02:46:42]

Dry run: This issue passed the CQ dry run.

[skobes, 2017-03-27 15:58:49]

skobes@chromium.org changed reviewers:
+ aelias@chromium.org, bokan@chromium.org

[skobes, 2017-03-27 15:58:49]

This is part 1; part 2 is http://crrev.com/2775863006 (WIP).

[bokan, 2017-03-27 16:25:13]

https://codereview.chromium.org/2770293003/diff/1/cc/trees/layer_tree_impl.cc
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/2770293003/diff/1/cc/trees/layer_tree_impl.cc...
cc/trees/layer_tree_impl.cc:546: target_tree->ShowScrollbars();
I think this relies on there always being a pending tree, which I think is the
case on Android but not necessarily all platforms (though maybe my understanding
is outdated here). Maybe this should be in LTHI::ActivateSyncTree?

[skobes, 2017-03-27 19:00:31]

https://codereview.chromium.org/2770293003/diff/1/cc/trees/layer_tree_impl.cc
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/2770293003/diff/1/cc/trees/layer_tree_impl.cc...
cc/trees/layer_tree_impl.cc:546: target_tree->ShowScrollbars();
On 2017/03/27 16:25:13, bokan wrote:
> I think this relies on there always being a pending tree, which I think is the
> case on Android but not necessarily all platforms (though maybe my
understanding
> is outdated here). Maybe this should be in LTHI::ActivateSyncTree?

Based on LTHI::CommitToActiveTree it looks like we create a pending tree when
threaded compositing is on, which I believe is everywhere except layout tests. 
Layout tests don't seem to create a ScrollbarAnimationController, so we should
be ok there.

[aelias_OOO_until_Jul13, 2017-03-28 00:10:15]

lgtm

[bokan, 2017-03-28 13:32:37]

On 2017/03/27 19:00:31, skobes wrote:
> https://codereview.chromium.org/2770293003/diff/1/cc/trees/layer_tree_impl.cc
> File cc/trees/layer_tree_impl.cc (right):
> 
>
https://codereview.chromium.org/2770293003/diff/1/cc/trees/layer_tree_impl.cc...
> cc/trees/layer_tree_impl.cc:546: target_tree->ShowScrollbars();
> On 2017/03/27 16:25:13, bokan wrote:
> > I think this relies on there always being a pending tree, which I think is
the
> > case on Android but not necessarily all platforms (though maybe my
> understanding
> > is outdated here). Maybe this should be in LTHI::ActivateSyncTree?
> 
> Based on LTHI::CommitToActiveTree it looks like we create a pending tree when
> threaded compositing is on, which I believe is everywhere except layout tests.

> Layout tests don't seem to create a ScrollbarAnimationController, so we should
> be ok there.

Ok thanks. lgtm then.

[skobes, 2017-03-28 16:32:05]

The CQ bit was checked by skobes@chromium.org

[skobes, 2017-03-28 16:32:05]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org,
aelias@chromium.org
Link to the patchset: https://codereview.chromium.org/2770293003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-28 16:33:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 16:43:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 16:43:48]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[skobes, 2017-03-28 16:47:50]

skobes@chromium.org changed reviewers:
+ pdr@chromium.org

[skobes, 2017-03-28 16:47:50]

+pdr for OWNERS

[pdr., 2017-03-28 17:40:08]

LGTM

[skobes, 2017-03-28 17:45:07]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2017-03-28 17:45:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 18:46:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490723107551260,
"parent_rev": "e2da63fad40fc329932c04030bca51f366ed721c", "commit_rev":
"56451775d90238d9def5e9663771de8d0ca7ef6f"}

[commit-bot: I haz the power, 2017-03-28 18:47:32]

Description was changed from

==========
Feed ScrollableArea::showOverlayScrollbars into ScrollbarAnimationController.

No behavior change yet since every scroll currently hits SAC::DidScrollUpdate,
but this adds plumbing to let Blink make the decision.

BUG=606395
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Feed ScrollableArea::showOverlayScrollbars into ScrollbarAnimationController.

No behavior change yet since every scroll currently hits SAC::DidScrollUpdate,
but this adds plumbing to let Blink make the decision.

BUG=606395
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2770293003
Cr-Commit-Position: refs/heads/master@{#460178}
Committed:
https://chromium.googlesource.com/chromium/src/+/56451775d90238d9def5e9663771...
==========

[commit-bot: I haz the power, 2017-03-28 18:47:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/56451775d90238d9def5e9663771...