Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1731)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2764613003: Media: Add MEDIALOG_CREATED event
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index b1dfbf11a00a9b902bc14fb8fdd748b826634f04..82b2f40bb81b700eec0aea1af64d893544d5d69e 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -2826,6 +2826,8 @@ blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
scoped_refptr<media::MediaLog> media_log(
new RenderMediaLog(url::Origin(frame_->getSecurityOrigin()).GetURL()));
+ media_log->SetStringProperty("ui_title", frame_->document().title().utf8());
wolenetz 2017/03/21 00:21:26 Are these two lines integral to the new MEDIALOG_C
+ media_log->SetStringProperty("ui_description", frame_->document().url().string().utf8());
sandersd (OOO until July 31) 2017/03/21 00:07:22 Looks like .utf8() can return a string referencing
bool embedded_media_experience_enabled = false;
#if defined(OS_ANDROID)

Powered by Google App Engine
This is Rietveld 408576698