Media: Add MEDIALOG_CREATED event

content/renderer/media/render_media_log.cc

Index: content/renderer/media/render_media_log.cc
diff --git a/content/renderer/media/render_media_log.cc b/content/renderer/media/render_media_log.cc
index 1169f685b5a81ec6885ef39e92a8cb96195c0301..5ce7c22a955123e62463767f2270e96f9e8fcd12 100644
--- a/content/renderer/media/render_media_log.cc
+++ b/content/renderer/media/render_media_log.cc
@@ -50,6 +50,8 @@ RenderMediaLog::RenderMediaLog(const GURL& security_origin)
       ipc_send_pending_(false) {
   DCHECK(RenderThread::Get())
       << "RenderMediaLog must be constructed on the render thread";
+  queued_media_events_.push_back(
+      *CreateEvent(media::MediaLogEvent::MEDIALOG_CREATED));

[wolenetz, 2017/03/21 00:21:26]

In a hypothetical scenario where someone just creates a RenderMediaLog but
delays a long time before doing any ::AddEvent, this MEDIALOG_CREATED event
won't get delivered to the browser until after that long delay. IOW, need to
trigger ipc send pending and the timer, etc (possibly refactoring into helper(s)
l.101-122 might work, or do something one-off here at risk of fragility if the
common case in l.101-122 changes later).

A safer refactor might be to have a private AddEventInternal which is the
current AddEvent, allowed only by the ctor and ::AddEvent, the latter containing
the new DCHECK_NE.

 }
 
 void RenderMediaLog::AddEvent(std::unique_ptr<media::MediaLogEvent> event) {
@@ -91,6 +93,8 @@ void RenderMediaLog::AddEvent(std::unique_ptr<media::MediaLogEvent> event) {
 
       // Just enqueue all other event types for throttled transmission.
       default:
+        DCHECK_NE(media::MediaLogEvent::MEDIALOG_CREATED, event->type)
+            << "MEDIALOG_CREATED events should not be sent manually";
         queued_media_events_.push_back(*event);
     }