chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java - Issue 2760103002: Merge WebApkConstants.EXTRA_WEBAPK_PACKAGE_NAME and ShortcutHelper.EXTRA_WEBAPK_PACKAGE_NAME

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java

Issue 2760103002: Merge WebApkConstants.EXTRA_WEBAPK_PACKAGE_NAME and ShortcutHelper.EXTRA_WEBAPK_PACKAGE_NAME (Closed)

Patch Set: Merge branch 'master' into package_name Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java ('K') | « chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java

index 53fc6a837d734e6108e07103ab676c44589402ce..1dc41650cdf4c6bdc9db1489048ae335068914a1 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java

@@ -28,6 +28,7 @@ import org.chromium.chrome.browser.ShortcutHelper;

import org.chromium.chrome.browser.browsing_data.UrlFilters;

import org.chromium.testing.local.BackgroundShadowAsyncTask;

import org.chromium.testing.local.LocalRobolectricTestRunner;

+import org.chromium.webapk.lib.common.WebApkConstants;

import java.util.Arrays;

import java.util.Collections;

@@ -628,8 +629,8 @@ public class WebappRegistryTest {

private Intent createWebApkIntent(String webappId, String webApkPackage) {

Intent intent = new Intent();

intent.putExtra(ShortcutHelper.EXTRA_ID, webappId)

- .putExtra(ShortcutHelper.EXTRA_URL, "https://foo.com")

- .putExtra(ShortcutHelper.EXTRA_WEBAPK_PACKAGE_NAME, webApkPackage);

+ .putExtra(ShortcutHelper.EXTRA_URL, "https://foo.com")

+ .putExtra(WebApkConstants.EXTRA_WEBAPK_PACKAGE_NAME, webApkPackage);

return intent;

}