Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4744)

Unified Diff: chrome/test/chromedriver/chrome/web_view_impl.cc

Issue 2743013002: Add webdriver endpoint to send custom debugger commands (Closed)
Patch Set: Adding stub, quick code reorg Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome/web_view_impl.h ('k') | chrome/test/chromedriver/client/chromedriver.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/web_view_impl.cc
diff --git a/chrome/test/chromedriver/chrome/web_view_impl.cc b/chrome/test/chromedriver/chrome/web_view_impl.cc
index 152450420f2267ede535ccf5caa5a4b1ccdfb695..bc80f1da416fecbc9ced40f88b46e05a5177e287 100644
--- a/chrome/test/chromedriver/chrome/web_view_impl.cc
+++ b/chrome/test/chromedriver/chrome/web_view_impl.cc
@@ -206,6 +206,23 @@ Status WebViewImpl::Reload(const Timeout* timeout) {
return client_->SendCommandWithTimeout("Page.reload", params, timeout);
}
+Status WebViewImpl::SendCommand(const std::string& cmd,
+ const base::DictionaryValue& params) {
+ return client_->SendCommand(cmd, params);
+}
+
+Status WebViewImpl::SendCommandAndGetResult(
+ const std::string& cmd,
+ const base::DictionaryValue& params,
+ std::unique_ptr<base::Value>* value) {
+ std::unique_ptr<base::DictionaryValue> result;
+ Status status = client_->SendCommandAndGetResult(cmd, params, &result);
+ if (status.IsError())
+ return status;
+ *value = std::move(result);
+ return Status(kOk);
+}
+
Status WebViewImpl::TraverseHistory(int delta, const Timeout* timeout) {
base::DictionaryValue params;
std::unique_ptr<base::DictionaryValue> result;
« no previous file with comments | « chrome/test/chromedriver/chrome/web_view_impl.h ('k') | chrome/test/chromedriver/client/chromedriver.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698