DescriptionAdd webdriver endpoint to send custom debugger commands
Since its introduction in Canary I became a big fan of the CSS rule usage
tracker and I'm looking forward to its introduction in Chrome stable.
I also thought it would be a great idea to run it periodically as part of the
e2e tests at work to collect the (un)used CSS rules instead of during manual
testing.
I then decided to implement a POC [1] to run the CSS tracker with Protractor.
This of course required some changes in Chromedriver, Protractor and WebDriver
JS Extender.
In particular, I had to change the Chromedriver so that I could send the
commands to start and stop the CSS rule usage tracking
(CSS.startRuleUsageTracking/CSS.stopRuleUsageTracking) to the remote debugger.
I thought of 3 possible implementations:
1) as part of the performance logging [2];
2) as a new endpoint of the Chromedriver to start/stop the CSS rule usage
tracking;
3) as a new endpoint of the Chromedriver to send any command directly to the
debugger, hence opening up the road to a whole series of tools able to send
commands directly to the debugger through the Chromedriver.
Of these 3 options, I implemented option 2 and 3 in this change.
If this change is acceptable, I'll proceed with the tests and fixing the linter issues.
Thanks,
EM.
[1] https://github.com/ventuno/css-usage-recorder/tree/ftr-css-recording
[2]
https://sites.google.com/a/chromium.org/chromedriver/logging/performance-log
BUG=
Review-Url: https://codereview.chromium.org/2743013002
Cr-Commit-Position: refs/heads/master@{#469275}
Committed: https://chromium.googlesource.com/chromium/src/+/711de0efbb675bd2a4a28ec47c9194d8e498e600
Patch Set 1 #Patch Set 2 : Adding name to AUTHORS file #Patch Set 3 : Removing start/stopcssruleusage cmds (et al). #Patch Set 4 : Remove CssTracker #Patch Set 5 : Remove CssTracker - contd #Patch Set 6 : New DevToolsEventsLogger #
Total comments: 4
Patch Set 7 : Addressing initial review comments #Patch Set 8 : Adding e2e test #Patch Set 9 : Adding e2e test #
Total comments: 10
Patch Set 10 : Addressing review comments #Patch Set 11 : Update test file #Patch Set 12 : Use std::move instead of DeepCopy #
Total comments: 10
Patch Set 13 : Rebasing and applying recommended cosmetic changes #Patch Set 14 : Fixing indentation #
Total comments: 6
Patch Set 15 : Indentation and style changes #
Total comments: 2
Patch Set 16 : Fix more indentation issues #Patch Set 17 : Adding stub, quick code reorg #Messages
Total messages: 80 (24 generated)
|