Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 27399004: Removed the implementation of CheckPlatformState. (Closed)

Created:
7 years, 2 months ago by Darren Krahn
Modified:
7 years, 2 months ago
Reviewers:
pastarmovj, DaleCurtis
CC:
chromium-reviews, nkostylev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, dkrahn+watch_chromium.org
Visibility:
Public.

Description

Removed the implementation of CheckPlatformState. The reasons for this are documented in the bug and in the code. BUG=chromium:307707 TEST=unit

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -85 lines) Patch
M chrome/browser/chromeos/attestation/platform_verification_flow.h View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_flow.cc View 4 chunks +6 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_flow_unittest.cc View 4 chunks +0 lines, -58 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Darren Krahn
CC: dalecurtis
7 years, 2 months ago (2013-10-15 21:53:21 UTC) #1
pastarmovj
lgtm
7 years, 2 months ago (2013-10-16 08:47:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dkrahn@chromium.org/27399004/1
7 years, 2 months ago (2013-10-16 18:15:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dkrahn@chromium.org/27399004/1
7 years, 2 months ago (2013-10-16 21:57:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dkrahn@chromium.org/27399004/1
7 years, 2 months ago (2013-10-17 01:55:21 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-17 05:10:20 UTC) #6
Darren Krahn
7 years, 2 months ago (2013-10-18 21:52:00 UTC) #7
Message was sent while issue was closed.
On 2013/10/17 05:10:20, I haz the power (commit-bot) wrote:
> Step "update" is always a major failure.
> Look at the try server FAQ for more details.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Abandoned in favor of https://chromiumcodereview.appspot.com/29943003/

Powered by Google App Engine
This is Rietveld 408576698